Fixes several code quality issues (Code Analysis)#387

Merged

NightOwl888 merged 72 commits intoapache:masterfrom NightOwl888:fix/code-quality-issues

Nov 10, 2020

+12,134-12,980

Commits on Nov 6, 2020

BUG: Lucene.Net.Document.CompressionTools: Pass the offset and length to the underlying MemoryStream
NightOwl888
committed
BUG: Lucene.Net.Analysis.Common.Tartarus.Snowball.Among: Fixed MethodObject property to reference private field instead of itself
NightOwl888
committed
BUG: Lucene.Net.TestFramework.Analysis.MockTokenizer: Pass the AttributeFactory argument that is provided as per the documentation comment. Note this bug exists in Lucene 4.8.0, also.
NightOwl888
committed
TestTargetFramework.props: Disable IDE0052 and IDE0060 in test projects
NightOwl888
committed
lucene-cli: Disabled IDE0060 warnings
NightOwl888
committed
Lucene.Net.Demo: Disabled IDE0060 warnings
NightOwl888
committed
PERFORMANCE: Fixes IDE0052 Remove unread private member, fixes IDE0060 Remove unused parameter
NightOwl888
committed
BUG: Lucene.Net.Util.ExceptionExtensions.GetSuppressedAsList(): Use J2N.Collections.Generic.List<T> so the call to ToString() will automatically list the exception messages
NightOwl888
committed

Commits on Nov 9, 2020

Commits on Nov 10, 2020