-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes several code quality issues (Code Analysis) #387
Merged
NightOwl888
merged 72 commits into
apache:master
from
NightOwl888:fix/code-quality-issues
Nov 10, 2020
Merged
Fixes several code quality issues (Code Analysis) #387
NightOwl888
merged 72 commits into
apache:master
from
NightOwl888:fix/code-quality-issues
Nov 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the underlying MemoryStream
…Object property to reference private field instead of itself
…uteFactory argument that is provided as per the documentation comment. Note this bug exists in Lucene 4.8.0, also.
…0 Remove unused parameter
…2N.Collections.Generic.List<T> so the call to ToString() will automatically list the exception messages
…em.Runtime.CompilerServices to skip our nullable attribute replacements for platforms that don't support them
…iter and subclasses which need more work)
…. Partially addresses apache#265.
…rPerField, IndexWriter, LogMergePolicy, SegmentCoreReaders, and SegmentReader to take advantage of the fact that TryGetValue returns a boolean
…AddXXXField() methods
…actories so it will display the dictionary contents
…to be in lexographical order by ID
… visible) warnings in tests
…llocations) warnings in tests
…ests (object and collection initialization can be simplified)
…mber) warnings in tests
…n exception clauses) warnings in tests
…') warnings because this functionality requires .NET Standard 2.1
…ers) warnings in tests
…stead of framework type names for type references) warnings in tests
…for type references
…w controlled by .editorconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
.editorconfig
file to take control over the code analysis rules.