Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug about PR #950, Related issues: #946. #965

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Fix bug about PR #950, Related issues: #946. #965

merged 1 commit into from
Sep 28, 2021

Conversation

lunescode
Copy link
Contributor

Problem: engine can't get env EUREKA_PREFER_IP.
Fix: add EUREKA_PREFER_IP into ecm engine Environment.

What is the purpose of the change

Related issues: #590.

Brief change log

  • Define EUREKA_PREFER_IP in Environment.scala
  • set EUREKA_PREFER_IP value in ProcessEngineConnLaunch.scala

Verifying this change

This change added tests and can be verified as follows:

set EUREKA_PREFER_IP =true, then start all service.
through scripts or resful interface to call job excute. if the job success finish,it will be ok.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no)
  • Anything that affects deployment: ( no )
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: ( no)

Documentation

  • Does this pull request introduce a new feature? no)
  • If yes, how is the feature documented? (not applicable )

Problem: engine can't get env EUREKA_PREFER_IP.
Fix: add EUREKA_PREFER_IP into ecm engine Environment.
@wushengyeyouya
Copy link
Contributor

Hi, I am sorry to inform you that Linkis-1.0.2 has been published, please resubmit this pr to Linkis-1.0.3, thank you very much!

@lunescode
Copy link
Contributor Author

but Linkis-1.0.3 is not syn 1.0.2 now

@peacewong peacewong changed the base branch from dev-1.0.2 to dev-1.0.3 September 28, 2021 06:46
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit dace507 into apache:dev-1.0.3 Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants