support both ip address and hostname for service discovery service call #946 #950
Conversation
lunescode
changed the title
lunescode
changed the title
| @@ -130,6 +131,14 @@ trait ProcessEngineConnLaunch extends EngineConnLaunch with Logging { | |||
| var springConf = Map("spring.application.name" -> GovernanceCommonConf.ENGINE_CONN_SPRING_NAME.getValue, | |||
| "server.port" -> engineConnPort, "spring.profiles.active" -> "engineconn", | |||
| "logging.config" -> s"classpath:${EnvConfiguration.LOG4J2_XML_FILE.getValue}") ++: discoveryMsgGenerator.generate(engineConnManagerEnv) | |||
|
|
|||
| //暂时通过判断engineConnManagerHost是否为IP地址来判断是否使用eureka.instance.prefer-ip-address，后续需要通过engineConnManagerEnv.properties获取相关属性 | |||
| logger.info(s"engineConnManagerHost:" + engineConnManagerEnv.engineConnManagerHost) | |||
There was a problem hiding this comment.
It is recommended to read Commvars to read this Key（EUREKA_PREFER_IP）, which will contain the key Value of the environment variable，CommonVars[String]("EUREKA_PREFER_IP", false)，If there is a value in the environment variable, it will not take the default false
There was a problem hiding this comment.
thanks, I will try and submit changes.
There was a problem hiding this comment.
I have updated，pls review.
There was a problem hiding this comment.
Thank you, you should use the environment variable EUREKA_PREFER_IP instead of spring parameters, because Commvar will read the environment variables
There was a problem hiding this comment.
Hello, to facilitate communication, you can add my wechat
There was a problem hiding this comment.
sorry,I can't find you webchat, I send my webchat to your email:[email protected],pls check it.
There was a problem hiding this comment.
in linkis-env.sh export EUREKA_PREFER_IP, in Configuration read it through CommonVars, and related code has been modified.
|
This is a great feature, thank you |
…ow through read vavlue from Commvars to decide.
…ow through read vavlue from Commvars to decide.
What is the purpose of the change
Linkis support ip address for service discovery service call，Related issues: #946 )
Brief change log
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
in config/linkis-env.sh ,set EUREKA_PREFER_IP=true, after install, view eureka page will see services name contains ipAddress,it works!
Does this pull request potentially affect one of the following parts:
Documentation