[incubator-kie-issues#1534] Remove mvn and gradlew wrapper from source #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcruzdev
changed the title
|
cc: @tiagobento @porcelli |
|
Multiple failures on PR checks... need to investigate here and merge when green. |
|
I will investigate it as soon as I get some time |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3724 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3724/4/display/redirect Test results:
Those are the test failures: PR check / Build projects / org.kie.kogito.it.JDBCPersistenceIT.testAsyncWIHAssertion condition defined as a org.kie.kogito.it.PersistenceTest 1 expectation failed.Expected status code <404> but was <200>. within 10 seconds. |
|
@mcruzdev you have this failure: 2024-10-16T14:55:24.4117300Z [INFO] Kogito :: Integration Tests :: Quarkus :: Gradle ... FAILURE [ 1.166 s] |
|
I got the issue, the maven calls
I will try to solve it downloading/using/deleting... or in another way... Maybe we can run gradle without calling |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3724 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3724/5/display/redirect Test results:
Those are the test failures: |
|
Okay, [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.1.1:exec (run-gradle) on project integration-tests-quarkus-gradle: Command execution failed. Cannot run program "gradle" (in directory "/home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3724@2/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/quarkus/integration-tests/integration-tests-quarkus-gradle/integration-tests-quarkus-gradle-project"): error=2, No such file or directory -> [Help 1]@porcelli can I add |
|
As discussed in apache/incubator-kie-issues#1577 weekly! I removed the integration tests for gradle. cc: @lucamolteni |
|
Test failure seems unrelated. |
porcelli
requested review from
porcelli,
tiagobento,
elguardian and
martinweiler
porcelli
approved these changes
Nov 1, 2024
martinweiler
approved these changes
Nov 1, 2024
|
I am here to help! And prepared to the next :) |
|
@mcruzdev thank you for the PR! Can you backport this to 10.0.x branch? We need this to move forward the release for 10.0.0. |
|
@pibizza im taking care of the backport |
porcelli
pushed a commit
to porcelli/incubator-kie-kogito-runtimes
that referenced
this pull request
Nov 2, 2024
porcelli
added a commit
that referenced
this pull request
Nov 4, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Closes apache/incubator-kie-issues#1534
Description:
Please make sure that your PR meets the following requirements:
Issue-XYZ Subject[0.9.x] Issue-XYZ SubjectHow to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.