Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Maven and Gradle wrapper from source #1534

Closed
Tracked by #1525
tiagobento opened this issue Oct 11, 2024 · 4 comments · Fixed by apache/incubator-kie-kogito-runtimes#3724 or apache/incubator-kie-tools#2664
Assignees

Comments

@tiagobento
Copy link

tiagobento commented Oct 11, 2024

Context on IPMC vote email: https://lists.apache.org/thread/oz1xfz48jwlw05sdy0wvtnrhn27jc72h

@porcelli
Copy link
Member

porcelli commented Oct 11, 2024

We have a community member that during community call volunteered to tackle this @mcruzdev

(can't assign to @mcruzdev because assign is limit to committers)

@mcruzdev
Copy link

mcruzdev commented Oct 19, 2024

incubator-kie-kogito-runtime

  • incubator-kie-kogito-runtimes/quarkus/integration-tests/integration-tests-quarkus-gradle/integration-tests-quarkus-gradle-project/gradle/wrapper/gradle-wrapper.jar
  • incubator-kie-kogito-runtimes/.mvn/wrapper/maven-wrapper.jar
  • incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-core/src/test/resources/empty.jar

PR

incubator-kie-tools

  • incubator-kie-tools/packages/stunner-editors/errai-ui/src/test/resources/less.jar

PR

incubator-kie-kogito-apps

  • incubator-kie-kogito-apps/.mvn/wrapper/maven-wrapper.jar

PR

cc: @porcelli @tiagobento

@porcelli
Copy link
Member

@mcruzdev not all .jars need to be removed;

Majority seems needed for testing the compiler and other internal pieces of the code that manipulate jars

@porcelli
Copy link
Member

i'd say that everything in test folders should be kept; and we'll just mention it somewhere - maybe in the notice file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment