-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clustertest): add basic MiniCluster module for distributed system #2615
Conversation
doc reference url is here |
hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/PDNodeWrapper.java
Outdated
Show resolved
Hide resolved
hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/PDNodeWrapper.java
Outdated
Show resolved
Hide resolved
hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/PDNodeWrapper.java
Outdated
Show resolved
Hide resolved
...graph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/config/ClusterConfImpl.java
Outdated
Show resolved
Hide resolved
hugegraph-it/hg-it-dist/src/assembly/static/multi/pd/A/conf/application.yml.template
Outdated
Show resolved
Hide resolved
hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/env/AbstractEnv.java
Outdated
Show resolved
Hide resolved
...aph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/AbstractNodeWrapper.java
Outdated
Show resolved
Hide resolved
...aph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/AbstractNodeWrapper.java
Outdated
Show resolved
Hide resolved
hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/BaseNodeWrapper.java
Outdated
Show resolved
Hide resolved
hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/BaseNodeWrapper.java
Outdated
Show resolved
Hide resolved
hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/PDNodeWrapper.java
Outdated
Show resolved
Hide resolved
hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/StoreNodeWrapper.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2615 +/- ##
============================================
- Coverage 47.76% 1.21% -46.55%
+ Complexity 821 8 -813
============================================
Files 719 697 -22
Lines 58918 56403 -2515
Branches 7597 7149 -448
============================================
- Hits 28141 685 -27456
- Misses 27953 55667 +27714
+ Partials 2824 51 -2773 ☔ View full report in Codecov by Sentry. |
...egraph-clustertest-minicluster/src/main/java/org/apache/hugegraph/ct/config/GraphConfig.java
Outdated
Show resolved
Hide resolved
...raph-cluster-test/hugegraph-clustertest-dist/src/assembly/static/pd-application.yml.template
Outdated
Show resolved
Hide resolved
...h-cluster-test/hugegraph-clustertest-dist/src/assembly/static/store-application.yml.template
Outdated
Show resolved
Hide resolved
...raph-clustertest-minicluster/src/main/java/org/apache/hugegraph/ct/base/ClusterConstant.java
Outdated
Show resolved
Hide resolved
...raph-clustertest-minicluster/src/main/java/org/apache/hugegraph/ct/base/ClusterConstant.java
Outdated
Show resolved
Hide resolved
...gegraph-clustertest-minicluster/src/main/java/org/apache/hugegraph/ct/base/HGTestLogger.java
Outdated
Show resolved
Hide resolved
.../hugegraph-clustertest-minicluster/src/main/java/org/apache/hugegraph/ct/env/EnvFactory.java
Outdated
Show resolved
Hide resolved
...-clustertest-minicluster/src/main/java/org/apache/hugegraph/ct/node/AbstractNodeWrapper.java
Outdated
Show resolved
Hide resolved
...-clustertest-minicluster/src/main/java/org/apache/hugegraph/ct/node/AbstractNodeWrapper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better avoid hardcoding 127.0.0.1
PS: Also remember to remove useless conf files in dist/static/
Cluster-Test CI is blocked by PR, which will fix the edgelabel_type in hugegraph-client |
Yes, it hasn't been released yet. For testing purpose, you can modify the ci temporarily to install the hugegraph-client that supports father-sub-edge from source(or only do it on your local), then have a test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary binary file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need it? Also add a TODO comment to reuse the config files in future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember add basic doc for it later
Purpose of the PR
subtask of #2593
Refer doc to get the design/details
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need