Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clustertest): add basic MiniCluster module for distributed system #2615

Merged
merged 51 commits into from
Oct 15, 2024

Conversation

HJ-Young
Copy link
Contributor

@HJ-Young HJ-Young commented Aug 4, 2024

Purpose of the PR

subtask of #2593

Refer doc to get the design/details

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@imbajin imbajin requested review from javeme and zyxxoo August 9, 2024 08:41
@imbajin imbajin added the feature New feature label Aug 9, 2024
@imbajin imbajin changed the title feat(it): add basic miniCluster environment feat(it): add basic MiniCluster module for distributed system Aug 9, 2024
@HJ-Young
Copy link
Contributor Author

HJ-Young commented Aug 10, 2024

doc reference url is here

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.21%. Comparing base (29ecc04) to head (e677136).

❗ There is a different number of reports uploaded between BASE (29ecc04) and HEAD (e677136). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (29ecc04) HEAD (e677136)
7 1
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #2615       +/-   ##
============================================
- Coverage     47.76%   1.21%   -46.55%     
+ Complexity      821       8      -813     
============================================
  Files           719     697       -22     
  Lines         58918   56403     -2515     
  Branches       7597    7149      -448     
============================================
- Hits          28141     685    -27456     
- Misses        27953   55667    +27714     
+ Partials       2824      51     -2773     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@VGalaxies VGalaxies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better avoid hardcoding 127.0.0.1

PS: Also remember to remove useless conf files in dist/static/

@HJ-Young
Copy link
Contributor Author

Cluster-Test CI is blocked by PR, which will fix the edgelabel_type in hugegraph-client

@Thespica
Copy link
Contributor

Cluster-Test CI is blocked by PR, which will fix the edgelabel_type in hugegraph-client

Hi @HJ-Young , this PR is ready, and will be merged soon.

@HJ-Young
Copy link
Contributor Author

Cluster-Test CI is blocked by PR, which will fix the edgelabel_type in hugegraph-client

Hi @HJ-Young , this PR is ready, and will be merged soon.

Hi, @Thespica . It seems that release jar package has not been updated?

@Thespica
Copy link
Contributor

Cluster-Test CI is blocked by PR, which will fix the edgelabel_type in hugegraph-client

Hi @HJ-Young , this PR is ready, and will be merged soon.

Hi, @Thespica . It seems that release jar package has not been updated?

Yes, it hasn't been released yet.

For testing purpose, you can modify the ci temporarily to install the hugegraph-client that supports father-sub-edge from source(or only do it on your local), then have a test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary binary file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Member

@imbajin imbajin Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need it? Also add a TODO comment to reuse the config files in future

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember add basic doc for it later

@VGalaxies VGalaxies merged commit 1a82d83 into apache:master Oct 15, 2024
17 checks passed
@imbajin imbajin added this to the 1.5.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build or deploy feature New feature lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants