Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): support "parent & child" EdgeLabel type #624

Merged
merged 29 commits into from
Oct 11, 2024
Merged

feat(client): support "parent & child" EdgeLabel type #624

merged 29 commits into from
Oct 11, 2024

Conversation

Thespica
Copy link
Contributor

@Thespica Thespica commented Oct 1, 2024 •
edited
Loading

Purpose of the PR

(related apache/incubator-hugegraph#2662)

Main Changes

added related fields and methods related to father-sub-edge in client, and adjusted some tests.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 1, 2024
@github-actions github-actions bot added the client hugegraph-client label Oct 1, 2024
@dosubot dosubot bot added the enhancement New feature or request label Oct 1, 2024
@VGalaxies VGalaxies self-requested a review October 3, 2024 03:04
@github-actions github-actions bot added loader hugegraph-loader spark labels Oct 8, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 54.68750% with 29 lines in your changes missing coverage. Please review.

Project coverage is 62.57%. Comparing base (b066b80) to head (ab04f08).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
...g/apache/hugegraph/structure/schema/EdgeLabel.java 55.81% 15 Missing and 4 partials ⚠️
...he/hugegraph/structure/constant/EdgeLabelType.java 55.55% 5 Missing and 3 partials ⚠️
...a/org/apache/hugegraph/structure/GraphElement.java 0.00% 0 Missing and 1 partial ⚠️
...ava/org/apache/hugegraph/structure/graph/Edge.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #624      +/-   ##
============================================
+ Coverage     62.49%   62.57%   +0.07%     
+ Complexity     1903     1004     -899     
============================================
  Files           262      175      -87     
  Lines          9541     5240    -4301     
  Branches        886      364     -522     
============================================
- Hits           5963     3279    -2684     
+ Misses         3190     1772    -1418     
+ Partials        388      189     -199

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imbajin
imbajin reviewed Oct 8, 2024
View reviewed changes
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/functional/FileLoadTest.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable auto run "space plugin" to avoid these changes

@VGalaxies VGalaxies mentioned this pull request Oct 9, 2024
Merged
@github-actions github-actions bot removed the spark label Oct 10, 2024
@Thespica Thespica changed the title [WIP]feat(client): support "parent & child" EdgeLabel type feat(client): support "parent & child" EdgeLabel type Oct 10, 2024
@HJ-Young HJ-Young mentioned this pull request Oct 11, 2024
Merged
11 tasks
VGalaxies
VGalaxies previously approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@VGalaxies VGalaxies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 11, 2024
imbajin
imbajin reviewed Oct 11, 2024
View reviewed changes
hugegraph-client/src/main/java/org/apache/hugegraph/structure/GraphElement.java
@@ -77,6 +77,7 @@ public GraphElement property(String name, Object value) {
E.checkArgument(ReflectionUtil.isSimpleType(clazz) ||
clazz.equals(UUID.class) ||
clazz.equals(Date.class) ||
clazz.equals(byte[].class) ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's for? (any context)

@imbajin
Copy link
Member

imbajin commented Oct 11, 2024 •
edited
Loading

⚠️: Also remember to update the doc for client/schema usage (if we have any breaking change on it)

@VGalaxies VGalaxies merged commit 6156dee into apache:master Oct 11, 2024
14 checks passed
@Thespica Thespica mentioned this pull request Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VGalaxies VGalaxies VGalaxies approved these changes

@imbajin imbajin imbajin approved these changes

Assignees
No one assigned
Labels
client hugegraph-client enhancement New feature or request lgtm This PR has been approved by a maintainer loader hugegraph-loader size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] support "parent & child" EdgeLabel type
3 participants
@Thespica @imbajin @VGalaxies