-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix NOTICE file & add license header #421
Conversation
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
=========================================
Coverage 62.55% 62.55%
Complexity 1866 1866
=========================================
Files 260 260
Lines 9405 9405
Branches 872 872
=========================================
Hits 5883 5883
Misses 3140 3140
Partials 382 382
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
INFO Totally checked 1554 files, valid: 595, invalid: 1, ignored: 958, fixed: 0
WARNING Failed to determine the comment style of file: NOTICE
WARNING Failed to determine the comment style of file: NOTICE
ERROR the following files don't have a valid license header:
NOTICE
ERROR one or more files does not have a valid license header
LICENSE
Outdated
@@ -1,4 +1,4 @@ | |||
Apache License | |||
Apache License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, also found in exist file dist/LICENSE
, copy from it:)
should also remove it in other repo
this already fixed in |
due to this PR is too big to review, separate it to 5 commits, coud use
rebase & merge
for it