Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix NOTICE file & add license header #421

Merged
merged 6 commits into from
Jan 14, 2023
Merged

chore: fix NOTICE file & add license header #421

merged 6 commits into from
Jan 14, 2023

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Jan 12, 2023

due to this PR is too big to review, separate it to 5 commits, coud use rebase & merge for it

@imbajin imbajin requested review from javeme and zyxxoo January 12, 2023 15:14
@imbajin imbajin added this to the 1.0.0 milestone Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #421 (190a139) into master (af01011) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #421   +/-   ##
=========================================
  Coverage     62.55%   62.55%           
  Complexity     1866     1866           
=========================================
  Files           260      260           
  Lines          9405     9405           
  Branches        872      872           
=========================================
  Hits           5883     5883           
  Misses         3140     3140           
  Partials        382      382           
Impacted Files Coverage Δ
...nt/src/main/java/org/apache/hugegraph/api/API.java 87.50% <ø> (ø)
.../java/org/apache/hugegraph/api/auth/AccessAPI.java 100.00% <ø> (ø)
...in/java/org/apache/hugegraph/api/auth/AuthAPI.java 69.23% <ø> (ø)
.../java/org/apache/hugegraph/api/auth/BelongAPI.java 100.00% <ø> (ø)
...n/java/org/apache/hugegraph/api/auth/GroupAPI.java 100.00% <ø> (ø)
...n/java/org/apache/hugegraph/api/auth/LoginAPI.java 100.00% <ø> (ø)
.../java/org/apache/hugegraph/api/auth/LogoutAPI.java 100.00% <ø> (ø)
...java/org/apache/hugegraph/api/auth/ProjectAPI.java 100.00% <ø> (ø)
.../java/org/apache/hugegraph/api/auth/TargetAPI.java 100.00% <ø> (ø)
...n/java/org/apache/hugegraph/api/auth/TokenAPI.java 100.00% <ø> (ø)
... and 250 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

zyxxoo
zyxxoo previously approved these changes Jan 12, 2023
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INFO Totally checked 1554 files, valid: 595, invalid: 1, ignored: 958, fixed: 0 
WARNING Failed to determine the comment style of file: NOTICE 
WARNING Failed to determine the comment style of file: NOTICE 
ERROR the following files don't have a valid license header: 
NOTICE 
ERROR one or more files does not have a valid license header 

LICENSE Outdated
@@ -1,4 +1,4 @@
Apache License
Apache License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a tab:
截屏2023-01-13 23 32 39

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, also found in exist file dist/LICENSE, copy from it:)

should also remove it in other repo

@imbajin
Copy link
Member Author

imbajin commented Jan 13, 2023

INFO Totally checked 1554 files, valid: 595, invalid: 1, ignored: 958, fixed: 0 
WARNING Failed to determine the comment style of file: NOTICE 
WARNING Failed to determine the comment style of file: NOTICE,
ERROR the following files don't have a valid license header: 
NOTICE 
ERROR one or more files does not have a valid license header 

this already fixed in release-1.0.0, could ignore it or merged #400 first

@imbajin imbajin merged commit 5a03ef2 into master Jan 14, 2023
@imbajin imbajin deleted the fix-header branch January 14, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants