Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dist): replace profile id & unify the dependencies/plugins #400

Merged
merged 10 commits into from
Jan 16, 2023
Merged

chore(dist): replace profile id & unify the dependencies/plugins #400

merged 10 commits into from
Jan 16, 2023

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Dec 16, 2022

No description provided.

@imbajin imbajin added ci Continuous integration apache labels Dec 16, 2022
@imbajin imbajin added this to the 1.0.0 milestone Dec 16, 2022
@imbajin imbajin self-assigned this Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022 •
edited
Loading

Codecov Report

Merging #400 (f7d5ce6) into master (5a03ef2) will not change coverage.
The diff coverage is n/a.

❗ Current head f7d5ce6 differs from pull request most recent head a8c04eb. Consider uploading reports for the commit a8c04eb to get more accurate results

@@            Coverage Diff            @@
##             master     #400   +/-   ##
=========================================
  Coverage     62.55%   62.55%           
  Complexity     1866     1866           
=========================================
  Files           260      260           
  Lines          9405     9405           
  Branches        872      872           
=========================================
  Hits           5883     5883           
  Misses         3140     3140           
  Partials        382      382

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

javeme
javeme reviewed Dec 17, 2022
View reviewed changes
hugegraph-tools/pom.xml
<!-- Pass these arguments to the deploy plugin. -->
<arguments>-Prelease</arguments>
<!-- Pass these arguments to the deployment plugin. -->
<arguments>-Papache-release</arguments>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Papache"?

Copy link
Member Author

@imbajin imbajin Dec 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the profile id refers the parent apache pom:
image

https://github.com/apache/maven-apache-parent/blob/99592e229c20f079c1998875e5c24556d217b491/pom.xml#L378

hugegraph-tools/pom.xml
</plugin>
</plugins>
</build>

<profiles>
<!-- mvn clean install -Prelease -->
<!-- mvn clean install -Papache-release -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

javeme
javeme previously approved these changes Dec 28, 2022
View reviewed changes
pom.xml
</compilerArgs>
</configuration>
</plugin>
<!-- <plugin>-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless code? add some comments if keep this code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless code? add some comments if keep this code

handle them later (not test well now)

javeme
javeme previously approved these changes Dec 30, 2022
View reviewed changes
javeme
javeme previously approved these changes Jan 1, 2023
View reviewed changes
javeme
javeme previously approved these changes Jan 4, 2023
View reviewed changes
@imbajin
Copy link
Member Author

imbajin commented Jan 4, 2023

@javeme this PR will merge until the release done, then use rebase & merge option

@javeme
Copy link
Contributor

javeme commented Jan 4, 2023

@javeme this PR will merge until the release done, then use rebase & merge option

get it

@imbajin imbajin mentioned this pull request Jan 13, 2023
Merged
@imbajin imbajin requested a review from zyxxoo January 13, 2023 16:57
javeme
javeme previously approved these changes Jan 13, 2023
View reviewed changes
zyxxoo
zyxxoo previously approved these changes Jan 14, 2023
View reviewed changes
@imbajin imbajin dismissed stale reviews from zyxxoo and javeme via f7d5ce6 January 14, 2023 14:43
@imbajin imbajin requested review from javeme and zyxxoo January 15, 2023 14:20
@imbajin imbajin merged commit e547a87 into master Jan 16, 2023
@imbajin imbajin deleted the release-1.0.0 branch January 16, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyxxoo zyxxoo zyxxoo approved these changes

@javeme javeme javeme approved these changes

Assignees

@imbajin imbajin

Labels
apache ci Continuous integration
Projects
No open projects
HugeGraph Release V1.0.0
Status: Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@imbajin @javeme @zyxxoo @JackyYangPassion @simon824 @z7658329