IGNITE-24014 Introduce a way to have key-value entries in configuration #4997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashapolo
force-pushed
the
ignite-24014
branch
2 times, most recently
from
6b77d97 to
4a7dff1
Compare
ibessonov
approved these changes
Jan 7, 2025
sashapolo
force-pushed
the
ignite-24014
branch
2 times, most recently
from
9a04615 to
f50591b
Compare
sashapolo
commented
Jan 10, 2025
| @@ -153,12 +156,16 @@ private boolean process0(RoundEnvironment roundEnvironment) { | |||
| return false; | |||
| } | |||
|
|
|||
| var injectedValueValidator = new InjectedValueValidator(processingEnv); | |||
There was a problem hiding this comment.
Note to reviewer: I'm going to refactor this part in a next PR to extract validators for all annotations, not just this one.
sashapolo
commented
Jan 10, 2025
| } | ||
| } | ||
|
|
||
| private boolean isValidValueAnnotationFieldType(TypeMirror type) { |
There was a problem hiding this comment.
Note to reviewer: this copy-paste will be refactored in a next PR
* NodeAttributeConfigurationSchema: attribute -> value * SystemPropertyConfigurationSchema: propertyValue -> value.
sashapolo
force-pushed
the
ignite-24014
branch
from
f50591b to
3e80b89
Compare
sashapolo
changed the title
ibessonov
reviewed
Jan 10, 2025
...pache/ignite/internal/cluster/management/configuration/NodeAttributeConfigurationSchema.java
Show resolved
Hide resolved
...va/org/apache/ignite/internal/configuration/processor/validators/InjectedValueValidator.java
Outdated
Show resolved
Hide resolved
...he/ignite/internal/configuration/utils/SystemDistributedConfigurationPropertyHolderTest.java
Outdated
Show resolved
Hide resolved
...ration/src/main/java/org/apache/ignite/internal/configuration/asm/InnerNodeAsmGenerator.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/ignite/internal/configuration/hocon/HoconObjectConfigurationSource.java
Outdated
Show resolved
Hide resolved
...ation/src/main/java/org/apache/ignite/internal/configuration/tree/ConverterToMapVisitor.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/ignite/internal/distributionzones/BaseDistributionZoneManagerTest.java
Outdated
Show resolved
Hide resolved
.../src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24014
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes