IGNITE-24014 Introduce a way to have key-value entries in configurati…

…on (#4997)

examples/config/ignite-config.conf

@@ -24,7 +24,7 @@ ignite {
         ]
     }
     nodeAttributes.nodeAttributes {
-        region.attribute = US
-        storage.attribute = SSD
+        region = US
+        storage = SSD
     }
 }

modules/cluster-management/src/integrationTest/java/org/apache/ignite/internal/cluster/management/topology/ItLogicalTopologyTest.java

@@ -67,7 +67,7 @@ class ItLogicalTopologyTest extends ClusterPerTestIntegrationTest {
             + "    port: {},\n"
             + "    nodeFinder.netClusterNodes: [ {} ]\n"
             + "  },\n"
-            + "  nodeAttributes.nodeAttributes: {region.attribute = US, storage.attribute = SSD},\n"
+            + "  nodeAttributes.nodeAttributes: {region = US, storage = SSD},\n"
             + "  storage.profiles: {lru_rocks.engine = rocksdb, segmented_aipersist.engine = aipersist},\n"
             + "  clientConnector.port: {},\n"
             + "  rest.port: {},\n"

modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/configuration/NodeAttributeConfigurationSchema.java

@@ -19,7 +19,7 @@
 
 import org.apache.ignite.configuration.annotation.Config;
 import org.apache.ignite.configuration.annotation.InjectedName;
-import org.apache.ignite.configuration.annotation.Value;
+import org.apache.ignite.configuration.annotation.InjectedValue;
 
 /**
  * Node's attribute configuration schema. User can specify any number of pairs (key, attribute) for a node through the local configuration
@@ -35,6 +35,6 @@ public class NodeAttributeConfigurationSchema {
     public String name;
 
     /** Node attribute field. */
-    @Value(hasDefault = true)
+    @InjectedValue(hasDefault = true)
     public String attribute = "";
 }

modules/configuration-annotation-processor/src/integrationTest/java/org/apache/ignite/internal/configuration/processor/ItConfigurationProcessorTest.java

@@ -615,6 +615,66 @@ void testSuccessfulCodeGenerationAbstractConfigurationAndItsDescendants() {
         configRootConfigurationInterfaceContent.contains("extends " + getConfigurationInterfaceName(abstractRootConfigSchema).simpleName());
     }
 
+    @Test
+    void testSuccessInjectedValueFieldCodeGeneration() {
+        String packageName = "org.apache.ignite.internal.configuration.processor.injectedvalue";
+
+        ClassName cls0 = ClassName.get(packageName, "ValidConfigurationSchema");
+
+        BatchCompilation batchCompile = batchCompile(cls0);
+
+        assertThat(batchCompile.getCompilationStatus()).succeededWithoutWarnings();
+
+        assertEquals(3, batchCompile.generated().size());
+
+        assertTrue(batchCompile.getBySchema(cls0).allGenerated());
+    }
+
+    @Test
+    void testMultipleInjectedValuesUnsuccessfulGeneration() {
+        String packageName = "org.apache.ignite.internal.configuration.processor.injectedvalue";
+
+        ClassName cls0 = ClassName.get(packageName, "MultipleInjectedValuesConfigurationSchema");
+
+        assertThrowsEx(
+                IllegalStateException.class,
+                () -> batchCompile(cls0),
+                "Field marked as @InjectedValue must be the only \"value\" field in the schema "
+                        + "org.apache.ignite.internal.configuration.processor.injectedvalue.MultipleInjectedValuesConfigurationSchema, "
+                        + "found: [firstValue, secondValue]"
+        );
+    }
+
+    @Test
+    void testValuesAndInjectedValueUnsuccessfulGeneration() {
+        String packageName = "org.apache.ignite.internal.configuration.processor.injectedvalue";
+
+        ClassName cls0 = ClassName.get(packageName, "ValueAndInjectedValueConfigurationSchema");
+
+        assertThrowsEx(
+                IllegalStateException.class,
+                () -> batchCompile(cls0),
+                "Field marked as @InjectedValue must be the only \"value\" field in the schema "
+                        + "org.apache.ignite.internal.configuration.processor.injectedvalue.ValueAndInjectedValueConfigurationSchema, "
+                        + "found: [secondValue, firstValue, thirdValue]"
+        );
+    }
+
+    @Test
+    void testUnsupportedFieldTypeUnsuccessfulGeneration() {
+        String packageName = "org.apache.ignite.internal.configuration.processor.injectedvalue";
+
+        ClassName cls0 = ClassName.get(packageName, "UnsupportedFieldTypeConfigurationSchema");
+
+        assertThrowsEx(
+                IllegalStateException.class,
+                () -> batchCompile(cls0),
+                "org.apache.ignite.internal.configuration.processor.injectedvalue.UnsupportedFieldTypeConfigurationSchema.firstValue "
+                        + "field must have one of the following types: boolean, int, long, double, String, UUID "
+                        + "or an array of aforementioned type."
+        );
+    }
+
     /**
      * Compile set of classes.
      *

modules/configuration-annotation-processor/src/integrationTest/resources/org/apache/ignite/internal/configuration/processor/injectedvalue/MultipleInjectedValuesConfigurationSchema.java

@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.configuration.processor.injectedvalue;
+
+import org.apache.ignite.configuration.annotation.Config;
+import org.apache.ignite.configuration.annotation.InjectedValue;
+
+@Config
+public class MultipleInjectedValuesConfigurationSchema {
+    @InjectedValue
+    public String firstValue;
+
+    @InjectedValue
+    public String secondValue;
+}

modules/configuration-annotation-processor/src/integrationTest/resources/org/apache/ignite/internal/configuration/processor/injectedvalue/UnsupportedFieldTypeConfigurationSchema.java

@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.configuration.processor.injectedvalue;
+
+import org.apache.ignite.configuration.annotation.Config;
+import org.apache.ignite.configuration.annotation.InjectedValue;
+
+@Config
+public class UnsupportedFieldTypeConfigurationSchema {
+    @InjectedValue
+    public Object firstValue;
+}

modules/configuration-annotation-processor/src/integrationTest/resources/org/apache/ignite/internal/configuration/processor/injectedvalue/ValidConfigurationSchema.java

@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.configuration.processor.injectedvalue;
+
+import org.apache.ignite.configuration.annotation.Config;
+import org.apache.ignite.configuration.annotation.InjectedName;
+import org.apache.ignite.configuration.annotation.InjectedValue;
+
+@Config
+public class ValidConfigurationSchema {
+    @InjectedName
+    public String name;
+
+    @InjectedValue
+    public String someValue;
+}

modules/configuration-annotation-processor/src/integrationTest/resources/org/apache/ignite/internal/configuration/processor/injectedvalue/ValueAndInjectedValueConfigurationSchema.java

@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.configuration.processor.injectedvalue;
+
+import org.apache.ignite.configuration.annotation.Config;
+import org.apache.ignite.configuration.annotation.InjectedValue;
+import org.apache.ignite.configuration.annotation.Value;
+
+@Config
+public class ValueAndInjectedValueConfigurationSchema {
+    @Value
+    public String firstValue;
+
+    @InjectedValue
+    public String secondValue;
+
+    @Value
+    public String thirdValue;
+}