Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nessie: Support ApiV2 for Nessie client #6712

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Nessie: Support ApiV2 for Nessie client #6712

merged 5 commits into from
Jun 15, 2023

Conversation

ajantha-bhat
Copy link
Member

@ajantha-bhat ajantha-bhat commented Jan 31, 2023 •
edited
Loading

  • The default version is v1 to avoid forcing users to change their URI in the existing jobs.
  • "client-api-version" catalog property is added to specify the API version in-case the user wants to use v2.

@ajantha-bhat ajantha-bhat marked this pull request as draft January 31, 2023 17:32
@ajantha-bhat ajantha-bhat marked this pull request as ready for review February 1, 2023 04:41
@ajantha-bhat
Copy link
Member Author

cc: @snazy, @dimas-b

@ajantha-bhat ajantha-bhat changed the title [WIP] Nessie: Support ApiV2 for Nessie client Nessie: Support ApiV2 for Nessie client Feb 1, 2023
dimas-b
dimas-b reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Thanks, @ajantha-bhat ! Just a minor comment about test code.

nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java Outdated Show resolved Hide resolved
nessie/src/test/java/org/apache/iceberg/nessie/TestNamespace.java Outdated Show resolved Hide resolved
@ajantha-bhat
Copy link
Member Author

Thanks @dimas-b for the review.
@snazy : Do you have any suggestions for this PR?

snazy
snazy suggested changes Feb 3, 2023
View reviewed changes
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s wait with this one until Nessie‘s v2 API is out of beta and included in a Nessie release.

Rushing this likely causes more trouble Than necessary

@ajantha-bhat
Copy link
Member Author

Let’s wait with this one until Nessie‘s v2 API is out of beta and included in a Nessie release.
Rushing this likely causes more trouble Than necessary

ACK.
Moved to Draft considering V2 APIs cannot change much once we expose them to the users via iceberg release.
PR can wait till v2 to move out of "beta" status.

@ajantha-bhat ajantha-bhat marked this pull request as draft February 3, 2023 15:57
@github-actions github-actions bot added the build label May 18, 2023
@ajantha-bhat ajantha-bhat changed the title Nessie: Support ApiV2 for Nessie client Nessie: Bump Nessie version to 0.59.0 and Support ApiV2 for Nessie client May 18, 2023
@ajantha-bhat ajantha-bhat changed the title Nessie: Bump Nessie version to 0.59.0 and Support ApiV2 for Nessie client Nessie: Support ApiV2 for Nessie client May 19, 2023
@ajantha-bhat ajantha-bhat marked this pull request as ready for review May 19, 2023 11:52
dimas-b
dimas-b approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ajantha-bhat !

@ajantha-bhat
Copy link
Member Author

@snazy: Can you please take a look at this PR again? Thanks

@ajantha-bhat ajantha-bhat mentioned this pull request May 26, 2023
Closed
@ajantha-bhat
Copy link
Member Author

ajantha-bhat commented Jun 14, 2023 •
edited
Loading

I just rebased the PR (as it was stale)

@snazy: The previous comments are addressed. Can you please take a look at this again? Thanks.

nastra
nastra approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment

nastra
nastra reviewed Jun 15, 2023
View reviewed changes
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieCatalog.java
ImmutableMap.of(
"ref",
ref,
CatalogProperties.URI,
uri,
"auth-type",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that not needed anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default value NONE itself. Hence, I just removed it to make less verbose.

@nastra nastra merged commit d29f392 into apache:master Jun 15, 2023
@ajantha-bhat ajantha-bhat mentioned this pull request Sep 29, 2023
Merged
@adutra adutra mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastra nastra nastra approved these changes

@dimas-b dimas-b dimas-b approved these changes

@snazy snazy snazy approved these changes

Assignees
No one assigned
Labels
build NESSIE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajantha-bhat @nastra @snazy @dimas-b