Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL extensions: add support for DROP IF EXISTS #7570

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

adutra
Copy link
Contributor

@adutra adutra commented Sep 29, 2023

No description provided.

@adutra adutra mentioned this pull request Sep 29, 2023
@@ -65,6 +65,8 @@ Dropping a tag `devTag` in the `nessie` catalog (in case it exists):

* `DROP TAG IF EXISTS devTag IN nessie`

Note: the `IF EXISTS` clause is optional and is only supported for Nessie 0.72 or higher.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Nessie SQL Extentions 0.72 .... This change looks purely client-side.

@adutra adutra merged commit d24025f into projectnessie:main Sep 29, 2023
@adutra adutra deleted the drop-if-exists branch September 29, 2023 14:57
@ajantha-bhat
Copy link
Contributor

ajantha-bhat commented Sep 29, 2023

By the time I finish review. PR was merged. Race condition.

Thanks for fixing this issue.

@bigluck
Copy link

bigluck commented Sep 29, 2023

Thanks guys!!

snazy added a commit to snazy/nessie that referenced this pull request Oct 9, 2023
snazy added a commit to snazy/nessie that referenced this pull request Oct 9, 2023
snazy added a commit to snazy/nessie that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants