Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LICENSE and NOTICE #413

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Update LICENSE and NOTICE #413

merged 2 commits into from
Feb 13, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 12, 2024 •
edited
Loading

This reverts commit e9e265a.

If I'm reading the page right I don't think we should add this to the notice:

  • Avro: Since we don't bundle the code, but just took some part of it, and want to attribute the author.
  • Thrift/Hive: We don't bundle any code, but just take the Python-compiled Thrift definitions.

HonahX
HonahX approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm my understanding: after reverting this, do we need another PR to remove Hive and Thrift from the LICENSE?

@Fokko Fokko changed the title Revert "Add Thrift and Hive to NOTICE (#410)" Update LICENSE and NOTICE Feb 12, 2024
@Fokko Fokko closed this Feb 13, 2024
@Fokko Fokko reopened this Feb 13, 2024
@Fokko Fokko force-pushed the fd-revert-change branch 2 times, most recently from 01efa73 to 1ae4ea4 Compare February 13, 2024 16:55
Fokko
Fokko commented Feb 13, 2024
View reviewed changes
@rdblue rdblue merged commit fbdf04b into apache:main Feb 13, 2024
6 checks passed
@Fokko Fokko added this to the PyIceberg 0.6.0 release milestone Feb 13, 2024
@Fokko Fokko deleted the fd-revert-change branch February 13, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonahX HonahX HonahX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PyIceberg 0.6.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@Fokko @HonahX @rdblue