-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Thrift and Hive to NOTICE #410
Conversation
@Fokko I'm not sure this is necessary since we don't actually bundle anything in the project. Per the ASF site
This is a little confusing because we did generate code based off those thrift definitions, but I don't think that really qualifies since we're not including anything that originated from those projects. |
@danielcweeks I just replied on the mailing list. We do ship the Python-generated Thrift definitions that are stored here: https://github.com/apache/iceberg-python/tree/main/vendor For example, the |
@Fokko, I think that this change is incorrect. It conflicts with the conventions that we use in Avro, Parquet, and the other Iceberg releases. LICENSE is where we put license information for code. NOTICE is for legally required notifications only. Here's the documentation on NOTICE:
Legally required notifications are things like attribution required by third-party licenses. We also include sections of other NOTICE files that need to be preserved because they apply to this project as well as the original project. License information should be included in the LICENSE file because it is the canonical place for license attribution. That's why the documentation states that NOTICE is for "notifications which are not satisfied by either the text of LICENSE or ..." It's fine if we don't ship code and should update LICENSE to reflect that, but we can't add this information to NOTICE. |
This reverts commit e9e265a.
This reverts commit e9e265a.
This reverts commit e9e265a.
No description provided.