-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Implement cascading parameter list #1978
[feature] Implement cascading parameter list #1978
Conversation
web-app/src/app/routes/monitor/monitor-edit/monitor-edit.component.ts
Outdated
Show resolved
Hide resolved
web-app/src/app/routes/monitor/monitor-edit/monitor-edit.component.ts
Outdated
Show resolved
Hide resolved
web-app/src/app/routes/monitor/monitor-new/monitor-new.component.ts
Outdated
Show resolved
Hide resolved
web-app/src/app/routes/monitor/monitor-new/monitor-new.component.ts
Outdated
Show resolved
Hide resolved
Fixed, thanks. @crossoverJie |
Hi, thanks for contribution. How about this rule:
eg:
|
Got it, I will refactor. |
Hi @tomsun28
BTW, are there any other protocols that require the use of cascading parameters? |
hi, great job👍, it seem no other params need cascading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
What's changed?
similar to #1976.
relate to #1705
The previous PR caused incorrect parameter display when monitoring the usage of other protocols. This PR fixes this bug.
When add a new monitor using HTTP:
2024-05-13_20-06-51.mp4
When edit a existing monitor using HTTP:
2024-05-13_20-07-15.mp4
Checklist
Add or update API