Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Implement cascading parameter list for SNMP protocol #1976

Merged
merged 7 commits into from
May 13, 2024

Conversation

zuobiao-zhou
Copy link
Member

What's changed?

close #1705

When add a new monitor using SNMP:

2024-05-13_12-28-51.mp4

When edit a existing monitor using SNMP:

2024-05-13_12-26-15.mp4

Backend checkstyle:
image

Frontend checkstyle:
image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@TJxiaobao TJxiaobao self-requested a review May 13, 2024 06:59
Copy link
Contributor

@TJxiaobao TJxiaobao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@TJxiaobao TJxiaobao merged commit ca93a65 into apache:master May 13, 2024
4 checks passed
@zuobiao-zhou zuobiao-zhou deleted the cascading-parameters branch May 13, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] <monitoring params support depende enable by other params>
2 participants