Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22311 - Update community docs to recommend use of "Co-authored-… #235

Merged
merged 2 commits into from
May 27, 2019

Conversation

nkalmar
Copy link
Contributor

@nkalmar nkalmar commented May 13, 2019

…by" in git commits

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 docker 174 Docker failed to build yetus/hbase:b002b0b.
Subsystem Report/Notes
GITHUB PR #235
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor

busbey commented May 13, 2019

that yetus failure is HBASE-22406

@HorizonNet
Copy link
Contributor

To see the final result of the book with the changes, I just re-triggered the build.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 22 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
_ master Compile Tests _
+1 mvninstall 234 master passed
0 refguide 703 branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 mvninstall 240 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
0 refguide 431 patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 asflicense 16 The patch does not generate ASF License warnings.
1697
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/2/artifact/out/Dockerfile
GITHUB PR #235
Optional Tests dupname asflicense refguide
uname Linux 74b9fe77fc34 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / fde0251
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/2/artifact/out/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/2/artifact/out/patch-site/book.html
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
Copy link
Contributor

LGTM, pending QA (which should be fine).

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 177 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
_ master Compile Tests _
+1 mvninstall 273 master passed
0 refguide 450 branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 mvninstall 269 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
0 refguide 456 patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 asflicense 16 The patch does not generate ASF License warnings.
1687
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/3/artifact/out/Dockerfile
GITHUB PR #235
Optional Tests dupname asflicense refguide
uname Linux f5c03b2cbece 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / fab2e15
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/3/artifact/out/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/3/artifact/out/patch-site/book.html
Max. process+thread count 81 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
Copy link
Contributor

@busbey Does the change also looks good for you?

@petersomogyi petersomogyi requested a review from busbey May 26, 2019 15:03
@petersomogyi petersomogyi merged commit b4dc778 into apache:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants