-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17650. [ARR] The router server-side rpc protocol PB supports asynchrony. #7139
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
46cb5f8
rebase
KeeProMise e9b5a4f
fix check
KeeProMise 15e4c0e
use RouterXXXXProtocolServerSideTranslatorPB
KeeProMise 8b5b099
fix ut
KeeProMise c37a39a
fix ut
KeeProMise 70a52af
fix check & javadoc
KeeProMise 3553ea1
fix check & javadoc
KeeProMise 8195f2d
fix check & javadoc
KeeProMise 1ef1f86
fix check & javadoc
KeeProMise 3107523
empty commit
KeeProMise c8c26b5
empty commit
KeeProMise 7475031
empty commit
KeeProMise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1,769 changes: 1,769 additions & 0 deletions
1,769
...org/apache/hadoop/hdfs/protocolPB/RouterClientNamenodeProtocolServerSideTranslatorPB.java
Large diffs are not rendered by default.
Oops, something went wrong.
59 changes: 59 additions & 0 deletions
59
...rg/apache/hadoop/hdfs/protocolPB/RouterGetUserMappingsProtocolServerSideTranslatorPB.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.hadoop.hdfs.protocolPB; | ||
|
||
import org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer; | ||
import org.apache.hadoop.thirdparty.protobuf.RpcController; | ||
import org.apache.hadoop.thirdparty.protobuf.ServiceException; | ||
import org.apache.hadoop.tools.GetUserMappingsProtocol; | ||
import org.apache.hadoop.tools.proto.GetUserMappingsProtocolProtos.GetGroupsForUserRequestProto; | ||
import org.apache.hadoop.tools.proto.GetUserMappingsProtocolProtos.GetGroupsForUserResponseProto; | ||
import org.apache.hadoop.tools.protocolPB.GetUserMappingsProtocolServerSideTranslatorPB; | ||
|
||
import static org.apache.hadoop.hdfs.protocolPB.AsyncRpcProtocolPBUtil.asyncRouterServer; | ||
|
||
public class RouterGetUserMappingsProtocolServerSideTranslatorPB | ||
extends GetUserMappingsProtocolServerSideTranslatorPB { | ||
private final RouterRpcServer server; | ||
private final boolean isAsyncRpc; | ||
|
||
public RouterGetUserMappingsProtocolServerSideTranslatorPB(GetUserMappingsProtocol impl) { | ||
super(impl); | ||
this.server = (RouterRpcServer) impl; | ||
this.isAsyncRpc = server.isAsync(); | ||
} | ||
|
||
@Override | ||
public GetGroupsForUserResponseProto getGroupsForUser( | ||
RpcController controller, | ||
GetGroupsForUserRequestProto request) throws ServiceException { | ||
if (!isAsyncRpc) { | ||
return super.getGroupsForUser(controller, request); | ||
} | ||
asyncRouterServer(() -> server.getGroupsForUser(request.getUser()), groups -> { | ||
GetGroupsForUserResponseProto.Builder builder = | ||
GetGroupsForUserResponseProto | ||
.newBuilder(); | ||
for (String g : groups) { | ||
builder.addGroups(g); | ||
} | ||
return builder.build(); | ||
}); | ||
return null; | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to add some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.