HDFS-17650. [ARR] The router server-side rpc protocol PB supports asynchrony. #7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hexiaoqiao @KeeProMise Sir, codes mainly from HDFS-17531. PTAL when you are free. Thanks a lot. |
KeeProMise
reviewed
Oct 31, 2024
There was a problem hiding this comment.
hi,@hfutatzhanghb After a brief look, please add some UT, you can refer to HDFS-17544. [ARR] The router client rpc protocol PB supports asynchrony.
Comment on lines
35
to
41
| private final static RefreshUserToGroupsMappingsResponseProto | ||
|
|
||
| protected final static RefreshUserToGroupsMappingsResponseProto | ||
| VOID_REFRESH_USER_GROUPS_MAPPING_RESPONSE = | ||
| RefreshUserToGroupsMappingsResponseProto.newBuilder().build(); | ||
|
|
||
| private final static RefreshSuperUserGroupsConfigurationResponseProto | ||
| protected final static RefreshSuperUserGroupsConfigurationResponseProto | ||
| VOID_REFRESH_SUPERUSER_GROUPS_CONFIGURATION_RESPONSE = |
There was a problem hiding this comment.
Hi, @hfutatzhanghb thanks for your contribution! It is recommended not to modify common because the pipeline will run for a long time. There are only 2 variables here, you can copy them directly to RouterRefreshUserMappingsProtocolServerSideTranslatorPB
There was a problem hiding this comment.
@KeeProMise Sir , thanks for reminding. fixed
Comment on lines
+105
to
+117
| public static <T> void asyncRouterServer(ServerReq<T> req, ServerRes<T> res) { | ||
| final ProtobufRpcEngineCallback2 callback = | ||
| ProtobufRpcEngine2.Server.registerForDeferredResponse2(); | ||
|
|
||
| CompletableFuture<Object> completableFuture = | ||
| CompletableFuture.completedFuture(null); | ||
| completableFuture.thenCompose(o -> { |
There was a problem hiding this comment.
It's better to add some comments
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
@KeeProMise Thanks for your suggestions. Will add soonly, |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
KeeProMise
force-pushed
the
HDFS-17531
branch
from
df6a5b6 to
ea3c4c8
Compare
KeeProMise
force-pushed
the
HDFS-17650
branch
from
2a50694 to
b5020d7
Compare
|
💔 -1 overall
This message was automatically generated. |
KeeProMise
force-pushed
the
HDFS-17650
branch
from
b5020d7 to
d1355d2
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
KeeProMise
force-pushed
the
HDFS-17650
branch
from
c5e833f to
15e4c0e
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@Hexiaoqiao Hi, if you have time, please help to take a look at this PR, thanks! The failed unit test is not related to this PR. It runs successfully on my local machine. |
KeeProMise
approved these changes
Jan 6, 2025
Hexiaoqiao
reviewed
Jan 9, 2025
@Hexiaoqiao Sir, we just make some fields and methods from private to protected in |
|
Got it. Make sense to me. +1. |
Hexiaoqiao
approved these changes
Jan 9, 2025
|
@hfutatzhanghb thanks for your contributions, @Hexiaoqiao thanks for your review! merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The router server-side rpc protocol PB supports asynchrony.
How to test
Added TestRouterAsyncRpc and TestRouterAsyncRpcMultiDestination tests for integration testing the asynchronous router functionality.