Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-18359. Update commons-cli from 1.2 to 1.5. (#5095). #6248

Open
wants to merge 1 commit into
base: branch-3.3
Choose a base branch
from
Open

HADOOP-18359. Update commons-cli from 1.2 to 1.5. (#5095). #6248

wants to merge 1 commit into from
+385 −434

Conversation

coheigea
Copy link
Contributor

@coheigea coheigea commented Nov 3, 2023 •
edited by slfan1989
Loading

Description of PR

Backport of security fix for https://issues.apache.org/jira/browse/HADOOP-18359

@slfan1989
Copy link
Contributor

@coheigea Thank you very much for your contribution! we will complete branch3.3 backport on this PR.

@slfan1989 slfan1989 changed the title HADOOP-18359. Update commons-cli from 1.2 to 1.5. (#5095). Contribute… HADOOP-18359. Update commons-cli from 1.2 to 1.5. (#5095). Nov 3, 2023
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 6m 54s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 6 new or modified test files.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 13m 53s Maven dependency ordering for branch
+1 💚 mvninstall 35m 19s branch-3.3 passed
+1 💚 compile 18m 47s branch-3.3 passed
+1 💚 checkstyle 2m 55s branch-3.3 passed
+1 💚 mvnsite 26m 9s branch-3.3 passed
+1 💚 javadoc 7m 21s branch-3.3 passed
+0 🆗 spotbugs 0m 22s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 72m 24s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 36s Maven dependency ordering for patch
+1 💚 mvninstall 41m 0s the patch passed
+1 💚 compile 18m 22s the patch passed
-1 ❌ javac 18m 22s /results-compile-javac-root.txt root generated 105 new + 1806 unchanged - 1 fixed = 1911 total (was 1807)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 2m 52s root: The patch generated 0 new + 367 unchanged - 26 fixed = 367 total (was 393)
+1 💚 mvnsite 23m 0s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 7m 14s the patch passed
+0 🆗 spotbugs 0m 23s hadoop-project has no data from spotbugs
+1 💚 shadedclient 70m 41s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 418m 23s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 27s The patch does not generate ASF License warnings.
802m 11s
Reason Tests
Failed junit tests hadoop.hdfs.tools.TestDFSAdmin
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.hdfs.server.namenode.TestNameNodeMXBean
hadoop.hdfs.TestDFSClientExcludedNodes
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6248/1/artifact/out/Dockerfile
GITHUB PR #6248
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname Linux 7e016e152000 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / f9319df
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu118.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6248/1/testReport/
Max. process+thread count 3142 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader hadoop-tools/hadoop-streaming hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-blockgen . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6248/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor

slfan1989 commented Nov 4, 2023 •
edited
Loading

I've readed the error in 'patch-unit-root.txt', which we previously encountered in the trunk branch. I will backport YARN-11595(#6253) to resolve this issue.

We can check the following link:
/patch-unit-root.txt

ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M1:test (default-test) on project hadoop-yarn-client: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M1:test failed: java.lang.NoClassDefFoundError: org/junit/jupiter/api/TestInfo: org.junit.jupiter.api.TestInfo -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hadoop-yarn-client

@slfan1989
Copy link
Contributor

@coheigea Can we retrigger jenkins compilation?

@coheigea
Copy link
Contributor Author

@slfan1989 done

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 14s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 6 new or modified test files.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 14m 0s Maven dependency ordering for branch
+1 💚 mvninstall 36m 6s branch-3.3 passed
+1 💚 compile 19m 4s branch-3.3 passed
+1 💚 checkstyle 3m 6s branch-3.3 passed
+1 💚 mvnsite 27m 40s branch-3.3 passed
+1 💚 javadoc 7m 28s branch-3.3 passed
+0 🆗 spotbugs 0m 23s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 69m 38s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 36s Maven dependency ordering for patch
+1 💚 mvninstall 41m 22s the patch passed
+1 💚 compile 18m 23s the patch passed
-1 ❌ javac 18m 23s /results-compile-javac-root.txt root generated 105 new + 1806 unchanged - 1 fixed = 1911 total (was 1807)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 2m 51s root: The patch generated 0 new + 367 unchanged - 26 fixed = 367 total (was 393)
+1 💚 mvnsite 22m 58s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 7m 10s the patch passed
+0 🆗 spotbugs 0m 23s hadoop-project has no data from spotbugs
+1 💚 shadedclient 69m 41s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 703m 32s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 54s The patch does not generate ASF License warnings.
1087m 34s
Reason Tests
Failed junit tests hadoop.fs.http.client.TestHttpFSFWithSWebhdfsFileSystem
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
hadoop.yarn.sls.nodemanager.TestNMSimulator
hadoop.yarn.sls.appmaster.TestAMSimulator
hadoop.yarn.client.api.impl.TestAMRMClient
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6248/2/artifact/out/Dockerfile
GITHUB PR #6248
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname Linux 1a903ef6956e 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 9ad9e79
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu118.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6248/2/testReport/
Max. process+thread count 3205 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader hadoop-tools/hadoop-streaming hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-blockgen . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6248/2/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coheigea @slfan1989 @hadoop-yetus