-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18359. Update commons-cli from 1.2 to 1.5. #5095
Conversation
💔 -1 overall
This message was automatically generated. |
Thanks @slfan1989 for the your contribution. Any CVE or security issue related for this update? Normally updating packages do affect downstream projects. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
hadoop-project/pom.xml
Outdated
<commons-cli.version>1.2</commons-cli.version> | ||
<commons-cli.version>1.3</commons-cli.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 1.5 released as well AFAIK, Can we attempt a move to that version?
@ayushtkn Thank you for your help to review the code! I will modify the version to 1.5 and refactor some code. |
If possible please keep the refactor separate if it isn't required for 1.5 upgrade, and we can merge both of them separately |
💔 -1 overall
This message was automatically generated. |
Jenkins has complains, can you check? The deprecation one, we need to fix |
Thank you so much for reviewing the code! I will fix it as soon as possible. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@ayushtkn Can you help review this PR again? Thank you very much! The unit test reported an error, not caused by our pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
@ayushtkn Thank you very much for helping to review the code! |
…ributed by Shilun Fan. Signed-off-by: Ayush Saxena <[email protected]>
…ributed by Shilun Fan. Signed-off-by: Ayush Saxena <[email protected]>
JIRA: HADOOP-18359. Update commons-cli from 1.2 to 1.5.