HADOOP-13386. Upgrade Avro to 1.9.2 (#3990)

[steveloughran]

#3990 for 3.3.4

[xkrogen]

I'm -1 on this. Avro versions follow the following convention (refer to this comment and this dev list thread):

<data compatibility> . <major library version> . <minor library version>

So while going from 1.7.7 to 1.9.2 may look like a minor version upgrade at first glance, it's actually an upgrade of 2 major versions (7 -> 9). This is way too big of a change to include into a patch release of Hadoop.

This isn't just a theoretical problem; Avro major version upgrades really do bring in breaking changes. We (LinkedIn) maintain an entire library devoted to smoothing over such breaking changes. Speaking from personal experience, without such a compatibility layer, a major version upgrade of Avro will cause many downstreams to break.

[steveloughran]

thanks for that. i was wondering about the risk of this one as far as code compilation goes.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	10m 18s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ branch-3.3.4 Compile Tests _
+0 🆗	mvndep	4m 47s		Maven dependency ordering for branch
+1 💚	mvninstall	34m 2s		branch-3.3.4 passed
+1 💚	compile	18m 53s		branch-3.3.4 passed
+1 💚	checkstyle	3m 14s		branch-3.3.4 passed
+1 💚	mvnsite	25m 25s		branch-3.3.4 passed
+1 💚	javadoc	8m 6s		branch-3.3.4 passed
+0 🆗	spotbugs	0m 27s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	26m 17s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for patch
+1 💚	mvninstall	28m 54s		the patch passed
+1 💚	compile	18m 18s		the patch passed
-1 ❌	javac	18m 18s	/results-compile-javac-root.txt	root generated 1 new + 1971 unchanged - 2 fixed = 1972 total (was 1973)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 9s		the patch passed
+1 💚	mvnsite	21m 35s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	xml	0m 7s		The patch has no ill-formed XML file.
+1 💚	javadoc	7m 52s		the patch passed
+0 🆗	spotbugs	0m 26s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	59m 29s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	701m 17s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	2m 1s		The patch does not generate ASF License warnings.
		1035m 40s

Reason	Tests
Failed junit tests	hadoop.yarn.csi.client.TestCsiClient
	hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerOvercommit
	hadoop.yarn.applications.distributedshell.TestDistributedShell
	hadoop.security.TestRaceWhenRelogin
	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
	hadoop.yarn.sls.appmaster.TestAMSimulator

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4580/1/artifact/out/Dockerfile
GITHUB PR	#4580
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml shellcheck shelldocs
uname	Linux fe8b40cd3ff5 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3.4 / 707db40
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4580/1/testReport/
Max. process+thread count	2142 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4580/1/console
versions	git=2.17.1 maven=3.6.0 shellcheck=0.4.6 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.