Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure. #2777

Merged
merged 1 commit into from
Mar 24, 2021
Merged

HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure. #2777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,7 @@ public void testAssumeRoleBadInnerAuth() throws Exception {
conf.set(SECRET_KEY, "not secret");
expectFileSystemCreateFailure(conf,
AWSBadRequestException.class,
"not a valid " +
"key=value pair (missing equal-sign) in Authorization header");
"IncompleteSignature");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the commit message "Removes string match so change in AWS S3 error message doesn't cause the test to fail", the complete string matching is to be removed right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. They've changed the string, and rather than try and keep up with whatever error message comes back, I'll just remove the match. We had to do the same with some of the assumed role tests a few releases back when they changed the max life of a role token from 60 minutes to 12h.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though you said you will completely remove the string matching. But we are still trying to match "IncompleteSignature"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I was confused. it's looking for the structured bit of the error message

}

@Test
Expand Down