HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure. #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ia4daa2cd0d552979d96b1475e01fb83ea9145e25
|
ran test case against S3 london; all good |
|
🎊 +1 overall
This message was automatically generated. |
|
This is ready to be reviewed @mukund-thakur |
| @@ -255,8 +255,7 @@ public void testAssumeRoleBadInnerAuth() throws Exception { | |||
| conf.set(SECRET_KEY, "not secret"); | |||
| expectFileSystemCreateFailure(conf, | |||
| AWSBadRequestException.class, | |||
| "not a valid " + | |||
| "key=value pair (missing equal-sign) in Authorization header"); | |||
| "IncompleteSignature"); | |||
There was a problem hiding this comment.
As per the commit message "Removes string match so change in AWS S3 error message doesn't cause the test to fail", the complete string matching is to be removed right?
There was a problem hiding this comment.
yes. They've changed the string, and rather than try and keep up with whatever error message comes back, I'll just remove the match. We had to do the same with some of the assumed role tests a few releases back when they changed the max life of a role token from 60 minutes to 12h.
There was a problem hiding this comment.
I though you said you will completely remove the string matching. But we are still trying to match "IncompleteSignature"
There was a problem hiding this comment.
sorry, I was confused. it's looking for the structured bit of the error message
|
@mukund-thakur any further comments? |
steveloughran
added a commit
to steveloughran/hadoop
that referenced
this pull request
Mar 23, 2021
* Select is spanned properly * HttpReferrer adds dynamic eval of current thread. * Every entry point in S3A code which creates a span is tagged @AuditSpan.AuditEntryPoint. This is to hint what is/isn't spanned. Public code MUST go through an AuditEntryPoint; internal code within an existing span MUST NOT -doing so will lose the first span. +revert test fix of ITestAssumeRole as it is covered in HADOOP-17476/apache#2777 Change-Id: I2cfdba907df0dcc76629e5af8effeed8d25d5933
|
thx |
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
…ache#2777) Contributed by Steve Loughran.
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
…failure. (apache#2777) Contributed by Steve Loughran. (cherry picked from commit bf2b431d15c84a62bfb6322f1c8702804d58ce28) Signed-off-by: Arpit Agarwal <[email protected]> Change-Id: I49f779ff3599104c920bc560e2c68d1bfed7ec6d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes string match so change in AWS S3 error message doesn't cause the test to fail