Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPREDUCE-6096.SummarizedJob Class Improvment #1

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

MAPREDUCE-6096.SummarizedJob Class Improvment #1

wants to merge 1 commit into from

Conversation

piaoyu
Copy link

@piaoyu piaoyu commented Sep 18, 2014

https://issues.apache.org/jira/browse/MAPREDUCE-6096

SummarizedJob class should be Improvment

When I Parse the JobHistory in the HistoryFile,I use the Hadoop System's map-reduce-client-core project org.apache.hadoop.mapreduce.jobhistory.JobHistoryParser class and HistoryViewer$SummarizedJob to Parse the JobHistoryFile(Just Like job_1408862281971_489761-1410883171851_XXX.jhist)
and it throw an Exception Just Like
Exception in thread "pool-1-thread-1" java.lang.NullPointerException
at org.apache.hadoop.mapreduce.jobhistory.HistoryViewer$SummarizedJob.(HistoryViewer.java:626)
at com.jd.hadoop.log.parse.ParseLogService.getJobDetail(ParseLogService.java:70)

After I'm see the SummarizedJob class I find that attempt.getTaskStatus() is NULL ,
So I change the order of attempt.getTaskStatus().equals (TaskStatus.State.FAILED.toString()) to
TaskStatus.State.FAILED.toString().equals(attempt.getTaskStatus())
and it works well .

@piaoyu piaoyu changed the title SummarizedJob Class Improvment MAPREDUCE-6096.SummarizedJob Class Improvment Sep 18, 2014
@piaoyu piaoyu changed the title MAPREDUCE-6096.SummarizedJob Class Improvment MAPREDUCE-6096.SummarizedJob Class Improvment(piaoyu) Sep 18, 2014
@piaoyu piaoyu changed the title MAPREDUCE-6096.SummarizedJob Class Improvment(piaoyu) MAPREDUCE-6096.SummarizedJob Class Improvment Sep 22, 2014
lirui-apache pushed a commit to lirui-apache/hadoop that referenced this pull request Nov 12, 2015
New file of AltFileInputStream.java to replace FileInputStream.java in apache/hadoop/HDFS
lhcxx pushed a commit to lhcxx/hadoop that referenced this pull request Feb 9, 2017
move tensorflow on yarn to the proper module
lhcxx pushed a commit to lhcxx/hadoop that referenced this pull request Feb 9, 2017
merge TensorFlow-YARN from zhankun's branch
mekasone pushed a commit to mekasone/hadoop that referenced this pull request Feb 19, 2017
xkrogen referenced this pull request in sunchao/hadoop Dec 11, 2017
This adds a new type of namenode: observer. A observer is like a standby
NN (in fact they share most of the code), EXCEPT it doesn't participate
in either NN failover (i.e., it is not part of the HA), or check pointing.

A observer can be specified through configuration. First, it needs to be
added into the config: dfs.ha.namenodes, just like a normal namenode,
together with other configs such as dfs.namenode.rpc-address,
dfs.namenode.http-address, etc. Second, it needs to be specified in a new
config: dfs.ha.observer.namenodes. This differentiate it from the ordinary
active/standby namenodes.

A observer can be used to serve read-only requests from HDFS client,
when the following two conditions are satisfied:

  1. the config dfs.client.failover.proxy.provider.<nameservice> is
     set to org.apache.hadoop.hdfs.server.namenode.ha.StaleReadProxyProvider.
  2. the config dfs.client.enable.stale-read is set to true

This also changes the way edit logs are loaded from the standby/observer NNs.
Instead of loading them all at once, the new implementation loads them
one batch at a time (default batch size is 10K edits) through multiple
iterations, while waiting for a short amount of time in between the
iterations (default waiting time is 100ms). This is to make sure the global
lock won't be held too long during loading edits. Otherwise, the RPC
processing time would suffer.

This patch does not include a mechanism for clients to specify the bound of
the staleness using journal transction ID: excluding this allows us to
deploy the observer more easily. In more specific, the deployment involves:

  1. restarting all datanodes with the updated configs. No binary change on
     datanodes is required.
  2. bootstraping and starting the observer namenode, with the updated
     configs. Existing namenodes do not need to change.

Future tasks:

  1. allow client to set a bound on staleness in observer in terms of time
     (e.g., 2min). If for some reason the lagging in edit tailing is larger
     than the bound, the client-side proxy provider will fail over all the
     RPCs to the active namenode.
  2. use journal transaction ID to ensure bound on staleness. This can be
     embedded in the RPC header.
  3. allow new standby/observer to be deployed without datanode restart.
chancez pushed a commit to chancez/hadoop that referenced this pull request May 13, 2019
Update image names/tags in scripts
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 37 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1105 trunk passed
+1 compile 33 trunk passed
+1 checkstyle 21 trunk passed
+1 mvnsite 33 trunk passed
+1 shadedclient 673 branch has no errors when building and testing our client artifacts.
+1 javadoc 15 trunk passed
0 spotbugs 70 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 68 trunk passed
_ Patch Compile Tests _
+1 mvninstall 32 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
-0 checkstyle 17 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 9 new + 138 unchanged - 9 fixed = 147 total (was 147)
+1 mvnsite 31 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 766 patch has no errors when building and testing our client artifacts.
+1 javadoc 14 the patch passed
+1 findbugs 73 the patch passed
_ Other Tests _
+1 unit 315 hadoop-mapreduce-client-core in the patch passed.
+1 asflicense 26 The patch does not generate ASF License warnings.
3383
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1/1/artifact/out/Dockerfile
GITHUB PR #1
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux e2956d7e8802 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 7f1b76c
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1/1/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1/1/testReport/
Max. process+thread count 1666 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 73 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1110 trunk passed
+1 compile 37 trunk passed
+1 checkstyle 29 trunk passed
+1 mvnsite 42 trunk passed
+1 shadedclient 794 branch has no errors when building and testing our client artifacts.
+1 javadoc 23 trunk passed
0 spotbugs 73 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 72 trunk passed
_ Patch Compile Tests _
+1 mvninstall 33 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
-0 checkstyle 21 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 9 new + 138 unchanged - 9 fixed = 147 total (was 147)
+1 mvnsite 33 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 821 patch has no errors when building and testing our client artifacts.
+1 javadoc 20 the patch passed
+1 findbugs 80 the patch passed
_ Other Tests _
+1 unit 334 hadoop-mapreduce-client-core in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
3648
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1/2/artifact/out/Dockerfile
GITHUB PR #1
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 05dfd2402eb6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 62efb63
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1/2/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1/2/testReport/
Max. process+thread count 1559 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1115 trunk passed
+1 compile 33 trunk passed
+1 checkstyle 24 trunk passed
+1 mvnsite 36 trunk passed
+1 shadedclient 678 branch has no errors when building and testing our client artifacts.
+1 javadoc 16 trunk passed
0 spotbugs 79 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 76 trunk passed
_ Patch Compile Tests _
+1 mvninstall 30 the patch passed
+1 compile 31 the patch passed
+1 javac 31 the patch passed
-0 checkstyle 20 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 9 new + 138 unchanged - 9 fixed = 147 total (was 147)
+1 mvnsite 33 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 735 patch has no errors when building and testing our client artifacts.
+1 javadoc 17 the patch passed
+1 findbugs 75 the patch passed
_ Other Tests _
+1 unit 335 hadoop-mapreduce-client-core in the patch passed.
+1 asflicense 28 The patch does not generate ASF License warnings.
3399
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1/3/artifact/out/Dockerfile
GITHUB PR #1
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 9f1a6a02e488 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e872ceb
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1/3/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1/3/testReport/
Max. process+thread count 1489 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1/3/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 80 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1215 trunk passed
+1 compile 38 trunk passed
+1 checkstyle 29 trunk passed
+1 mvnsite 40 trunk passed
+1 shadedclient 844 branch has no errors when building and testing our client artifacts.
+1 javadoc 19 trunk passed
0 spotbugs 79 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 77 trunk passed
_ Patch Compile Tests _
+1 mvninstall 34 the patch passed
+1 compile 29 the patch passed
+1 javac 29 the patch passed
-0 checkstyle 24 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 9 new + 138 unchanged - 9 fixed = 147 total (was 147)
+1 mvnsite 30 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 829 patch has no errors when building and testing our client artifacts.
+1 javadoc 17 the patch passed
+1 findbugs 79 the patch passed
_ Other Tests _
+1 unit 317 hadoop-mapreduce-client-core in the patch passed.
+1 asflicense 27 The patch does not generate ASF License warnings.
3804
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1/4/artifact/out/Dockerfile
GITHUB PR #1
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 951061f878d4 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 00b5a27
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1/4/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1/4/testReport/
Max. process+thread count 1074 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 71 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1059 trunk passed
+1 compile 29 trunk passed
+1 checkstyle 21 trunk passed
+1 mvnsite 32 trunk passed
+1 shadedclient 664 branch has no errors when building and testing our client artifacts.
+1 javadoc 15 trunk passed
0 spotbugs 64 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 63 trunk passed
_ Patch Compile Tests _
+1 mvninstall 28 the patch passed
+1 compile 25 the patch passed
+1 javac 24 the patch passed
-0 checkstyle 18 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 9 new + 138 unchanged - 9 fixed = 147 total (was 147)
+1 mvnsite 28 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 710 patch has no errors when building and testing our client artifacts.
+1 javadoc 14 the patch passed
+1 findbugs 71 the patch passed
_ Other Tests _
+1 unit 323 hadoop-mapreduce-client-core in the patch passed.
+1 asflicense 27 The patch does not generate ASF License warnings.
3266
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1/5/artifact/out/Dockerfile
GITHUB PR #1
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 8148a8366ab2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 8943e13
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1/5/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1/5/testReport/
Max. process+thread count 1638 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1/5/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1102 trunk passed
+1 compile 30 trunk passed
+1 checkstyle 23 trunk passed
+1 mvnsite 33 trunk passed
+1 shadedclient 669 branch has no errors when building and testing our client artifacts.
+1 javadoc 15 trunk passed
0 spotbugs 65 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 62 trunk passed
_ Patch Compile Tests _
+1 mvninstall 28 the patch passed
+1 compile 24 the patch passed
+1 javac 24 the patch passed
-0 checkstyle 18 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 9 new + 138 unchanged - 9 fixed = 147 total (was 147)
+1 mvnsite 31 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 710 patch has no errors when building and testing our client artifacts.
+1 javadoc 14 the patch passed
+1 findbugs 70 the patch passed
_ Other Tests _
+1 unit 324 hadoop-mapreduce-client-core in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
3285
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1/6/artifact/out/Dockerfile
GITHUB PR #1
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 51a1c09aa4e7 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 4cb22cd
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1/6/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1/6/testReport/
Max. process+thread count 1644 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1/6/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 35 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1244 trunk passed
+1 compile 37 trunk passed
+1 checkstyle 31 trunk passed
+1 mvnsite 41 trunk passed
+1 shadedclient 867 branch has no errors when building and testing our client artifacts.
+1 javadoc 19 trunk passed
0 spotbugs 85 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 83 trunk passed
_ Patch Compile Tests _
+1 mvninstall 38 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
-0 checkstyle 21 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 9 new + 138 unchanged - 9 fixed = 147 total (was 147)
+1 mvnsite 35 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 818 patch has no errors when building and testing our client artifacts.
+1 javadoc 15 the patch passed
+1 findbugs 93 the patch passed
_ Other Tests _
+1 unit 338 hadoop-mapreduce-client-core in the patch passed.
+1 asflicense 28 The patch does not generate ASF License warnings.
3838
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1/7/artifact/out/Dockerfile
GITHUB PR #1
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 982e009d191f 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 28fb4b5
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1/7/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1/7/testReport/
Max. process+thread count 1172 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1/7/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1093 trunk passed
+1 compile 38 trunk passed
+1 checkstyle 30 trunk passed
+1 mvnsite 42 trunk passed
+1 shadedclient 787 branch has no errors when building and testing our client artifacts.
+1 javadoc 21 trunk passed
0 spotbugs 77 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 74 trunk passed
_ Patch Compile Tests _
+1 mvninstall 36 the patch passed
+1 compile 29 the patch passed
+1 javac 29 the patch passed
-0 checkstyle 24 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 9 new + 138 unchanged - 9 fixed = 147 total (was 147)
+1 mvnsite 38 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 915 patch has no errors when building and testing our client artifacts.
+1 javadoc 19 the patch passed
+1 findbugs 86 the patch passed
_ Other Tests _
+1 unit 351 hadoop-mapreduce-client-core in the patch passed.
+1 asflicense 30 The patch does not generate ASF License warnings.
3732
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1/8/artifact/out/Dockerfile
GITHUB PR #1
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 24936564d27c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3329257
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1/8/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1/8/testReport/
Max. process+thread count 1608 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1/8/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 52s trunk passed
+1 💚 compile 0m 43s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 0m 35s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 checkstyle 0m 40s trunk passed
+1 💚 mvnsite 0m 41s trunk passed
+1 💚 shadedclient 17m 8s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 24s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 21s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗 spotbugs 1m 22s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 20s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 33s the patch passed
+1 💚 compile 0m 33s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 0m 33s the patch passed
+1 💚 compile 0m 30s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 0m 30s the patch passed
-0 ⚠️ checkstyle 0m 28s /diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 9 new + 138 unchanged - 9 fixed = 147 total (was 147)
+1 💚 mvnsite 0m 33s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 46s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 20s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 19s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 findbugs 1m 32s the patch passed
_ Other Tests _
+1 💚 unit 7m 33s hadoop-mapreduce-client-core in the patch passed.
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
85m 42s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1/1/artifact/out/Dockerfile
GITHUB PR #1
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 9fa6df5c667f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c3134ab
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1/1/testReport/
Max. process+thread count 1340 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1/1/console
versions git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 56s trunk passed
+1 💚 compile 0m 41s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 0m 38s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 checkstyle 0m 37s trunk passed
+1 💚 mvnsite 0m 42s trunk passed
+1 💚 javadoc 0m 27s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 24s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 1m 15s trunk passed
+1 💚 shadedclient 14m 32s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 31s the patch passed
+1 💚 compile 0m 31s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 0m 31s the patch passed
+1 💚 compile 0m 29s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 0m 29s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 26s /results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 9 new + 138 unchanged - 9 fixed = 147 total (was 147)
+1 💚 mvnsite 0m 33s the patch passed
+1 💚 javadoc 0m 17s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 16s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 1m 18s the patch passed
+1 💚 shadedclient 14m 6s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 6m 47s hadoop-mapreduce-client-core in the patch passed.
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
81m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1/1/artifact/out/Dockerfile
GITHUB PR #1
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux cd73b5bd00d2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / bfcf11d
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1/1/testReport/
Max. process+thread count 1573 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 53s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 25s trunk passed
+1 💚 compile 0m 38s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 0m 34s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 0m 34s trunk passed
+1 💚 mvnsite 0m 39s trunk passed
+1 💚 javadoc 0m 25s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 20s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 1m 18s trunk passed
+1 💚 shadedclient 22m 17s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 31s the patch passed
+1 💚 compile 0m 32s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 0m 32s the patch passed
+1 💚 compile 0m 28s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 0m 28s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 25s /results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 8 new + 138 unchanged - 9 fixed = 146 total (was 147)
+1 💚 mvnsite 0m 32s the patch passed
+1 💚 javadoc 0m 15s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 14s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 1m 19s the patch passed
+1 💚 shadedclient 22m 14s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 5m 35s hadoop-mapreduce-client-core in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
95m 51s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1/1/artifact/out/Dockerfile
GITHUB PR #1
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 82d1f6e7b3d9 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / bfcf11d
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1/1/testReport/
Max. process+thread count 949 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

szilard-nemeth added a commit to szilard-nemeth/hadoop that referenced this pull request Mar 9, 2022
Yifan122 added a commit to Yifan122/hadoop-apache that referenced this pull request Apr 16, 2023
NyteKnight pushed a commit to NyteKnight/hadoop that referenced this pull request Jun 25, 2024
NyteKnight pushed a commit to NyteKnight/hadoop that referenced this pull request Jun 25, 2024
flaming-archer pushed a commit to flaming-archer/hadoop that referenced this pull request Jul 17, 2024
adjust bpid format for HW Pacific storage
singer-bin pushed a commit to singer-bin/hadoop that referenced this pull request Dec 19, 2024
singer-bin pushed a commit to singer-bin/hadoop that referenced this pull request Dec 19, 2024
NULL tuples causes NPE when writing
singer-bin pushed a commit to singer-bin/hadoop that referenced this pull request Dec 19, 2024
…ng/binary column trunk are null

In case of all nulls in a binary column, statistics object read from file metadata is empty, and should return true for all nulls check for the column. Even if column has no values, it can be ignored.

The other way is to fix this behaviour in the writer, but is that what we want ?

Author: Yash Datta <[email protected]>
Author: Alex Levenson <[email protected]>
Author: Yash Datta <[email protected]>

Closes apache#99 from saucam/npe and squashes the following commits:

5138e44 [Yash Datta] PARQUET-136: Remove unreachable block
b17cd38 [Yash Datta] Revert "PARQUET-161: Trigger tests"
82209e6 [Yash Datta] PARQUET-161: Trigger tests
aab2f81 [Yash Datta] PARQUET-161: Review comments for the test case
2217ee2 [Yash Datta] PARQUET-161: Add a test case for checking the correct statistics info is recorded in case of all nulls in a column
c2f8d6f [Yash Datta] PARQUET-161: Fix the write path to write statistics object in case of only nulls in the column
97bb517 [Yash Datta] Revert "revert TestStatisticsFilter.java"
a06f0d0 [Yash Datta] Merge pull request apache#1 from isnotinvain/alexlevenson/PARQUET-161-136
b1001eb [Alex Levenson] Fix statistics isEmpty, handle more edge cases in statistics filter
0c88be0 [Alex Levenson] revert TestStatisticsFilter.java
1ac9192 [Yash Datta] PARQUET-136: Its better to not filter chunks for which empty statistics object is returned. Empty statistics can be read in case of 1. pre-statistics files, 2. files written from current writer that has a bug, as it does not write the statistics if column has all nulls
e5e924e [Yash Datta] Revert "PARQUET-136: In case of all nulls in a binary column, statistics object read from file metadata is empty, and should return true for all nulls check for the column"
8cc5106 [Yash Datta] Revert "PARQUET-136: fix hasNulls to cater to the case where all values are nulls"
c7c126f [Yash Datta] PARQUET-136: fix hasNulls to cater to the case where all values are nulls
974a22b [Yash Datta] PARQUET-136: In case of all nulls in a binary column, statistics object read from file metadata is empty, and should return true for all nulls check for the column
singer-bin pushed a commit to singer-bin/hadoop that referenced this pull request Dec 19, 2024
...thod

Author: Alex Levenson <[email protected]>
Author: Konstantin Shaposhnikov <[email protected]>
Author: kostya-sh <[email protected]>

Closes apache#171 from kostya-sh/PARQUET-246 and squashes the following commits:

75950c5 [kostya-sh] Merge pull request apache#1 from isnotinvain/PR-171
a718309 [Konstantin Shaposhnikov] Merge remote-tracking branch 'refs/remotes/origin/master' into PARQUET-246
0367588 [Alex Levenson] Add regression test for PR-171
94e8fda [Alex Levenson] Merge branch 'master' into PR-171
0a9ac9f [Konstantin Shaposhnikov] [PARQUET-246] bugfix: reset all DeltaByteArrayWriter state in reset() method
singer-bin pushed a commit to singer-bin/hadoop that referenced this pull request Dec 19, 2024
In response to PARQUET-251 created an integration test that generates random values and compares the statistics against the values read from a parquet file.

There are two tools classes `DataGenerationContext` and `RandomValueGenerators` which are located in the same package as the unit test. I'm sure there is a better place to put these, but I leave that to your discretion.

Thanks
Reuben

Author: Reuben Kuhnert <[email protected]>
Author: Ryan Blue <[email protected]>

Closes apache#255 from sircodesalotOfTheRound/stats-validation and squashes the following commits:

680e96a [Reuben Kuhnert] Merge pull request apache#1 from rdblue/PARQUET-355-stats-validation-tests
9f0033f [Ryan Blue] PARQUET-355: Use ColumnReaderImpl.
7d0b4fe [Reuben Kuhnert] PARQUET-355: Add Statistics Validation Test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants