HDFS-11227: Set read timeout for peer #171
Open
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 9, 2016 16:47
…node fs.hdfs.data.socket.size to be set in core-site.xml. If the node is not found, the default value is -1, so socket buffer size would not be set.
… config node fs.hdfs.data.socket.size to be set in core-site.xml. If the node is not found, the default value is -1, so socket buffer size would not be set. Will add this commit in separate PR" This reverts commit 6c29642.
jojochuang
reviewed
Jun 22, 2019
| try { | ||
| peer.setReadTimeout(conf.socketTimeout); | ||
| } | ||
| catch(IOException e){} |
There was a problem hiding this comment.
According to the javadoc, it should return a null if it is unable to establish a connection. I think it should also return a null in this case as well.
jojochuang
reviewed
Jun 22, 2019
| try { | ||
| peer.setReadTimeout(conf.socketTimeout); | ||
| } | ||
| catch(IOException e){} |
There was a problem hiding this comment.
Return null upon exception
jojochuang
reviewed
Jun 22, 2019
| try { | ||
| peer.setReadTimeout(conf.socketTimeout); | ||
| } | ||
| catch(IOException e){} |
There was a problem hiding this comment.
return null upon exception
jojochuang
requested changes
Jun 22, 2019
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Author: Prateek Maheshwari <[email protected]> Reviewers: Jacob Maes <[email protected]> Closes apache#171 from prateekm/disable-flaky-test
This was referenced Dec 8, 2021
This was referenced Dec 16, 2021
This was referenced Mar 17, 2022
This was referenced Mar 25, 2022
This was referenced Apr 1, 2022
This was referenced Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read timeout is not set with peer in org.apache.hadoop.hdfs.BlockReaderFactory, so BlockReader read doesn't timeout.