-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GOBBLIN-1747] add job.name and job.id to kafka and compaction workunits #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-Lo
approved these changes
Nov 23, 2022
Codecov Report
@@ Coverage Diff @@
## master #3607 +/- ##
============================================
+ Coverage 49.36% 51.37% +2.00%
+ Complexity 9199 7145 -2054
============================================
Files 1741 1335 -406
Lines 67495 49882 -17613
Branches 7715 5563 -2152
============================================
- Hits 33322 25626 -7696
+ Misses 31055 21995 -9060
+ Partials 3118 2261 -857 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Will-Lo
approved these changes
Nov 23, 2022
phet
pushed a commit
to phet/gobblin
that referenced
this pull request
Dec 3, 2022
…its (apache#3607) * add job.name and job.id to kafka workunits * fix unit test * add job.name and job.id to compaction source workunits also Co-authored-by: umustafi <[email protected]>
phet
added a commit
to phet/gobblin
that referenced
this pull request
Dec 5, 2022
* upstream/master: [GOBBLIN-1747] add job.name and job.id to kafka and compaction workunits (apache#3607) [GOBBLIN-1746] Add fs.uri to FsDatasetDescriptor to support copy between volumes in GaaS (apache#3605) [GOBBLIN-1743] Ensure GobblinTaskRunner works without Yarn use (apache#3602) [GOBBLIN-1745] Fix bug in SimpleKafkaSpecProducer (apache#3604) [GOBBLIN-1739]Define Datanodes and Dataset Descriptor for Iceberg (apache#3596) do not close DestinationDatasetHandlerService prematurely (apache#3601) [GOBBLIN-1720]Add ancestors owner permissions preservations for iceberg distcp (apache#3577) [HOTFIX] Fix checkstyleMain (apache#3600) [GOBBLIN-1736] Add metrics for change stream monitor and mysql quota manager (apache#3593) [GOBBLIN-1737] Fix bug when using mysql user quota manager (apache#3595) Correct a log line and GTE with currect number of total task count (apache#3591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
adding job.name and job.id to workunits created by kafka and compaction source. these configs can be used by dataset handlers or other part of code flow
Tests
trivial changes. tested manually
Commits