[GOBBLIN-1736] Add metrics for change stream monitor and mysql quota manager #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 18, 2022 17:20
umustafi
reviewed
Oct 28, 2022
| @@ -80,18 +87,21 @@ public void init(Collection<Dag<JobExecutionPlan>> dags) { | |||
|
|
|||
| @Override | |||
| public void checkQuota(Collection<Dag.DagNode<JobExecutionPlan>> dagNodes) throws IOException { | |||
| try (Connection connection = this.quotaStore.dataSource.getConnection()) { | |||
| try (Connection connection = this.quotaStore.dataSource.getConnection(); | |||
| Timer.Context context = metricContext.timer(RuntimeMetrics.GOBBLIN_MYSQL_QUOTA_MANAGER_CHECK_QUOTA_TIME).time()) { | |||
There was a problem hiding this comment.
when do we call stop for this?
There was a problem hiding this comment.
This is in try clause, when this try section finish, the context will close automatically
Comment on lines
50
to
51
| public static final String GOBBLIN_MYSQL_QUOTA_MANAGER_QUOTA_EXCEEDS_REQUESTS = ServiceMetricNames.GOBBLIN_SERVICE_PREFIX + "gobblin.mysql.quota.manager.quotaExceeds.requests"; | ||
| public static final String GOBBLIN_MYSQL_QUOTA_MANAGER_CHECK_QUOTA_TIME = ServiceMetricNames.GOBBLIN_SERVICE_PREFIX + "gobblin.mysql.quota.manager.check.quota.time"; |
There was a problem hiding this comment.
Names are a bit hard to understand without reading the code GOBBLIN_MYSQL_QUOTA_MANAGER_QUOTA_REQUESTS_EXCEEDED so it implies number of requests exceeding quota. gobblin_mysql_quota_manager_time_to_check_quota for the second, is it measuring amount of time it takes to do the whole check?
Codecov Report
@@ Coverage Diff @@
## master #3593 +/- ##
============================================
- Coverage 46.88% 46.87% -0.01%
- Complexity 10660 10673 +13
============================================
Files 2118 2120 +2
Lines 82981 83078 +97
Branches 9238 9252 +14
============================================
+ Hits 38902 38943 +41
- Misses 40515 40565 +50
- Partials 3564 3570 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
umustafi
reviewed
Nov 4, 2022
| private ContextAwareMeter killsInvoked; | ||
| private ContextAwareMeter resumesInvoked; | ||
| private ContextAwareMeter unexpectedErrors; | ||
| private Meter messageProcessedMeter; |
There was a problem hiding this comment.
why do you use normal Meter instead of ContextAwareMeter? Also we should end all the names in "Meter" or none of them ie: messagesProcessed or killsInvokedMeter
umustafi
approved these changes
Nov 11, 2022
phet
pushed a commit
to phet/gobblin
that referenced
this pull request
Dec 3, 2022
…manager (apache#3593) * address comments * use connectionmanager when httpclient is not cloesable * [GOBBLIN-1730] Include flow execution id when try to cancel/submit job using SimpleKafkaSpecProducer * remove unnecessary dependency * [GOBBLIN-1736] Add metrics for change stream monitor and mysql quota manager * Revert "remove unnecessary dependency" This reverts commit d6871dc. * Revert "[GOBBLIN-1730] Include flow execution id when try to cancel/submit job using SimpleKafkaSpecProducer" This reverts commit f13e6ea. * address comments * address comments Co-authored-by: Zihan Li <[email protected]>
phet
added a commit
to phet/gobblin
that referenced
this pull request
Dec 5, 2022
* upstream/master: [GOBBLIN-1747] add job.name and job.id to kafka and compaction workunits (apache#3607) [GOBBLIN-1746] Add fs.uri to FsDatasetDescriptor to support copy between volumes in GaaS (apache#3605) [GOBBLIN-1743] Ensure GobblinTaskRunner works without Yarn use (apache#3602) [GOBBLIN-1745] Fix bug in SimpleKafkaSpecProducer (apache#3604) [GOBBLIN-1739]Define Datanodes and Dataset Descriptor for Iceberg (apache#3596) do not close DestinationDatasetHandlerService prematurely (apache#3601) [GOBBLIN-1720]Add ancestors owner permissions preservations for iceberg distcp (apache#3577) [HOTFIX] Fix checkstyleMain (apache#3600) [GOBBLIN-1736] Add metrics for change stream monitor and mysql quota manager (apache#3593) [GOBBLIN-1737] Fix bug when using mysql user quota manager (apache#3595) Correct a log line and GTE with currect number of total task count (apache#3591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Add metrics for change stream monitor and mysql quota manager to monitor the health of the components in warm standby mode
Tests
unit test
Commits