-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #630] RocketMQProducerImpl cannot load config properties from classpath #631
Merged
xwm1992
merged 2 commits into
apache:develop
from
ruanwenjun:dev_wenjun_fixRocketMQConsumerConfig
Dec 13, 2021
Merged
[ISSUE #630] RocketMQProducerImpl cannot load config properties from classpath #631
xwm1992
merged 2 commits into
apache:develop
from
ruanwenjun:dev_wenjun_fixRocketMQConsumerConfig
Dec 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@xwm1992 Please take a look. |
ruanwenjun
force-pushed
the
dev_wenjun_fixRocketMQConsumerConfig
branch
4 times, most recently
from
December 9, 2021 11:39
b540a13
to
9156e76
Compare
The ci failed, due to the current license check rules. This can be fixed by #535. |
ruanwenjun
force-pushed
the
dev_wenjun_fixRocketMQConsumerConfig
branch
from
December 10, 2021 03:39
8e877a6
to
50451ef
Compare
xwm1992
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ruanwenjun
force-pushed
the
dev_wenjun_fixRocketMQConsumerConfig
branch
2 times, most recently
from
December 13, 2021 11:52
b0df1bd
to
5d19083
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixRocketMQConsumerConfig
branch
3 times, most recently
from
December 13, 2021 11:57
d654d34
to
614e193
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixRocketMQConsumerConfig
branch
from
December 13, 2021 12:22
614e193
to
e95eacb
Compare
xwm1992
added a commit
that referenced
this pull request
Dec 24, 2021
* readme.md * [ISSUE #563] SDK SUPPORT CLOUD EVENT (#575) * SDK SUPPORT CLOUD EVENT * SDK SUPPORT CLOUD EVENT * SDK SUPPORT CLOUD EVENT * SDK SUPPORT CLOUD EVENT * SDK SUPPORT CLOUD EVENT * SDK SUPPORT CLOUD EVENT * SDK SUPPORT CLOUD EVENT * SDK SUPPORT CLOUD EVENT * SDK SUPPORT CLOUD EVENT Co-authored-by: wangshaojie <[email protected]> * [Feature #562] support cloudevents api in eventmesh-connector-api module (#578) * [Feature #564] Support CloudEvents protocols for pub/sub in EventMesh-feature design * support cloudevents api in eventmesh-connector-api module * fix checkStyle * fix checkStyle * fix checkStyle * 1.support LifeCycle.java 2.update Consumer and Producer * fix remove the extra blank line * connector support cloud event (#586) Co-authored-by: wangshaojie <[email protected]> * [Feature #562] Support CloudEvents for pub/sub in EventMesh runtime (#587) * [Feature #564] Support CloudEvents protocols for pub/sub in EventMesh-feature design * support cloudevents api in eventmesh-connector-api module * fix checkStyle * fix checkStyle * fix checkStyle * 1.support LifeCycle.java 2.update Consumer and Producer * fix remove the extra blank line * support cloudEvents * support cloudEvents * support cloudEvents * support cloudEvents * support cloudevents * support cloudEvents * support cloudEvents * support cloudEvents * [Feature #562] Implement CloudEvents protocol adaptor (#595) * [Feature #564] Support CloudEvents protocols for pub/sub in EventMesh-feature design * support cloudevents api in eventmesh-connector-api module * fix checkStyle * fix checkStyle * fix checkStyle * 1.support LifeCycle.java 2.update Consumer and Producer * fix remove the extra blank line * support cloudEvents * Add files via upload * Update README.md * support cloudEvents * support cloudEvents * [ISSUE #580] Add checkstyle gradle plugin (#581) * Add checkstyle gradle plugin, change plugin package * skip check in ci * support cloudEvents * support cloudevents * update wechat-official qr code * update mesh-helper qr code * Add files via upload * update README.md * update README.md * Update .asf.yaml * support cloudEvents * support cloudEvents * [ISSUE #588] Fix typo in README.md (#589) close #588 * support cloudEvents * [Bug #590] Consumer subscription topic is invalid (#590) (#592) * [Bug #590] Consumer subscription topic is invalid (#590) * [Bug #590] Consumer subscription topic is invalid (#590) close #590 * support cloudEvents adaptor * [Feature #562] Implement CloudEvents adaptor Co-authored-by: Eason Chen <[email protected]> Co-authored-by: Wenjun Ruan <[email protected]> Co-authored-by: Nicholas Zhan <[email protected]> Co-authored-by: hagsyn <[email protected]> * [Feature #562] Implement EventMeshMessage protocol adaptor (#597) * [Feature #564] Support CloudEvents protocols for pub/sub in EventMesh-feature design * support cloudevents api in eventmesh-connector-api module * fix checkStyle * fix checkStyle * fix checkStyle * 1.support LifeCycle.java 2.update Consumer and Producer * fix remove the extra blank line * support cloudEvents * Add files via upload * Update README.md * support cloudEvents * support cloudEvents * [ISSUE #580] Add checkstyle gradle plugin (#581) * Add checkstyle gradle plugin, change plugin package * skip check in ci * support cloudEvents * support cloudevents * update wechat-official qr code * update mesh-helper qr code * Add files via upload * update README.md * update README.md * Update .asf.yaml * support cloudEvents * support cloudEvents * [ISSUE #588] Fix typo in README.md (#589) close #588 * support cloudEvents * [Bug #590] Consumer subscription topic is invalid (#590) (#592) * [Bug #590] Consumer subscription topic is invalid (#590) * [Bug #590] Consumer subscription topic is invalid (#590) close #590 * support cloudEvents adaptor * [Feature #562] Implement CloudEvents adaptor * [Feature #562] Implement EventMeshMessage protocol adaptor * supplement apache header Co-authored-by: Eason Chen <[email protected]> Co-authored-by: Wenjun Ruan <[email protected]> Co-authored-by: Nicholas Zhan <[email protected]> Co-authored-by: hagsyn <[email protected]> * Remove some unused code (#591) * Remove some unused code in sdk module * Remove some unused code in sdk module * fixed a wrong url in cn-doc (#585) close #596 * resolve_exception->Consumer subscription topic is invalid #590 (#598) close #590 * update Eventmeshmessage plugin (#599) * [Feature #564] Support CloudEvents protocols for pub/sub in EventMesh-feature design * support cloudevents api in eventmesh-connector-api module * fix checkStyle * fix checkStyle * fix checkStyle * 1.support LifeCycle.java 2.update Consumer and Producer * fix remove the extra blank line * support cloudEvents * Add files via upload * Update README.md * support cloudEvents * support cloudEvents * [ISSUE #580] Add checkstyle gradle plugin (#581) * Add checkstyle gradle plugin, change plugin package * skip check in ci * support cloudEvents * support cloudevents * update wechat-official qr code * update mesh-helper qr code * Add files via upload * update README.md * update README.md * Update .asf.yaml * support cloudEvents * support cloudEvents * [ISSUE #588] Fix typo in README.md (#589) close #588 * support cloudEvents * [Bug #590] Consumer subscription topic is invalid (#590) (#592) * [Bug #590] Consumer subscription topic is invalid (#590) * [Bug #590] Consumer subscription topic is invalid (#590) close #590 * support cloudEvents adaptor * [Feature #562] Implement CloudEvents adaptor * [Feature #562] Implement EventMeshMessage protocol adaptor * supplement apache header * 1.update package name 2.support build.gradle and gradle.properties 3.support ProtocolTransportObject Co-authored-by: Eason Chen <[email protected]> Co-authored-by: Wenjun Ruan <[email protected]> Co-authored-by: Nicholas Zhan <[email protected]> Co-authored-by: hagsyn <[email protected]> * Update eventmesh-store-quickstart.md * Update README.md * Add slack icon (#601) * Add protocol producer in java sdk (#600) * Add protocol producer in sdk * Refactor callback handler * Add tcp protocol client * Change Tcp interface (#603) * update http push request and adaptor (#606) 1.update http push request 2.update http in protocol adaptor * update java sdk (#607) * Fix standalone connector interface, fix example (#608) * fix compile error (#609) * update java sdk * fix compile error * Java sdk update (#610) * update java sdk * fix compile error * fix sdk error * Add EventMeshTCPClient, this client wrap the sub/sub client (#611) * runtime update (#612) * update java sdk * fix compile error * fix sdk error * 1.remove the openmessage from connector-api 2.fix the standalone connector * Java sdk update (#615) * update java sdk * fix compile error * fix sdk error 1.remove the openmessage from connector-api 2.fix the standalone connector * 1.fix the standalone connector 2.fix the sdk * eventmesh-admin-rocketmq submodule and createTopic REST API (#530) * eventmesh-admin-rocketmq submodule and createTopic draft API * add license header * change to /topicmanage * fix build error * fix some code check style issues close #435 #346 * Fix some small issue (#616) * eventmeshmessage protocol adaptor for tcp (#618) 1.fix the standalone connector 2.fix eventmeshmessage protocol adaptor for tcp * remove openschema implementation from em project * eventmesh message protocol for http pub/sub with standalone connector (#619) 1.fix eventmeshmessage protocol adaptor for http with standalone connector * create topic command (#531) * create topic command * address review comments * fix build and add createtopic method to standalone module * fix build issue * fix a few remaining code check issues * fix test close #346 * Java sdk update cloudevents pub/sub (#620) 1.cloudevents protocol tcp pub/sub for sdk * Update README.md * Change TCP Decoder and Encoder (#621) * cloudevents protocol tcp pub/sub for sdk (#622) 1.cloudevents protocol tcp pub/sub for sdk * cloudevents protocol tcp pub/sub for sdk (#623) cloudevents protocol tcp pub/sub for sdk * cloudevents protocol http pub/sub for sdk (#625) cloudevents protocol http pub/sub for sdk * cloudevents protocol pub/sub for http sdk (#627) fix cloudevents protocol pub/sub for http sdk * Add AbstractEventMeshTCPSubHandler (#624) * Add AbstractEventMeshTCPSubHandler * cloudevents/eventmesh message protocol pub/sub for sdk in rocketmq-connector (#628) * fix cloudevents/eventmesh message protocol pub/sub for sdk in rocketmq-connector * cloudevents/eventmesh message protocol pub/sub for sdk in rocketmq-connector (#629) * fix cloudevents/eventmesh message protocol pub/sub for sdk in rocketmq-connector * Safely delete useless log4j dependencies * Safely delete outdated metrics dependencies * Sately delete useless collections4 dependency * Safely delete useless commons dependencies * Reback to the collections4, but let it not in api dependency * Could not remove text for Safe Ramdom implementation * Fix build error * Add collection4 * Fix build error * Revert "Safely delete outdated metrics dependencies" This reverts commit 92287b0. * Change to api dependency * Remove doclint warnings * Depracated checkstyle check error temporarily, we should remove it when we polish later * sync request/response for sdk in rocketmq-connector (#634) fix sync request/response for sdk in rocketmq-connector * Update .asf.yaml * Update .asf.yaml * fix conflicts and update the code (#635) * Add files via upload * Update README.md * [ISSUE #580] Add checkstyle gradle plugin (#581) * Add checkstyle gradle plugin, change plugin package * skip check in ci * update wechat-official qr code * update mesh-helper qr code * Add files via upload * update README.md * update README.md * Update .asf.yaml * [ISSUE #588] Fix typo in README.md (#589) close #588 * [Bug #590] Consumer subscription topic is invalid (#590) (#592) * [Bug #590] Consumer subscription topic is invalid (#590) * [Bug #590] Consumer subscription topic is invalid (#590) close #590 * fixed a wrong url in cn-doc (#585) close #596 * resolve_exception->Consumer subscription topic is invalid #590 (#598) close #590 * Update eventmesh-store-quickstart.md * Update README.md * Add slack icon (#601) * eventmesh-admin-rocketmq submodule and createTopic REST API (#530) * eventmesh-admin-rocketmq submodule and createTopic draft API * add license header * change to /topicmanage * fix build error * fix some code check style issues close #435 #346 * create topic command (#531) * create topic command * address review comments * fix build and add createtopic method to standalone module * fix build issue * fix a few remaining code check issues * fix test close #346 * Update README.md * Safely delete useless log4j dependencies * Safely delete outdated metrics dependencies * Sately delete useless collections4 dependency * Safely delete useless commons dependencies * Reback to the collections4, but let it not in api dependency * Could not remove text for Safe Ramdom implementation * Fix build error * Add collection4 * Fix build error * Revert "Safely delete outdated metrics dependencies" This reverts commit 92287b0. * Change to api dependency * Remove doclint warnings * Depracated checkstyle check error temporarily, we should remove it when we polish later * Update .asf.yaml * Update .asf.yaml Co-authored-by: Eason Chen <[email protected]> Co-authored-by: Wenjun Ruan <[email protected]> Co-authored-by: Nicholas Zhan <[email protected]> Co-authored-by: hagsyn <[email protected]> Co-authored-by: sarihuangshanrong <[email protected]> Co-authored-by: yuri <[email protected]> Co-authored-by: vongosling <[email protected]> * supply apache header * Remove license name, add LICENSE file * resolve conflict * remove some not used in binary license * set connector plugin to standalone * Add license check shell * Add jdk11 and otherOS in github ci * Add comments * resolve javadoc failed on jdk11 * Change skywalking uses repo to main * GRPC producer publish API * remove unused files * remove unused plugin * [ISSUE #630] RocketMQProducerImpl cannot load config properties from classpath (#631) * Fix RocketMqConsumer cannot load properties in classpath close #630 * [Bug #646] Missing the rocketmq message properties during protocol conversion (#647) * [Bug #646] Missing the rocketmq message properties during protocol conversion * fix checkstyle and gradle module dependency * fix conflicts close #646 * grpc publish with cloudevents * [MINOR] Hide ctx in callback function and update contributing doc (#644) 1. Hide ctx in callback function 2. Resolve compile warning of loss spi 3. Update contributing doc 4.Remove codeql * [ISSUE #405] remove some unused code (#649) * [ISSUE #405] remove some unused code * [Issue #417] grpc publish API * [MINOR] Add third-part dependencies licenses (#650) * [MINOR] supply the license and update the third party license file name (#653) [MINOR] supply the license and update the third party license file name * [ISSUE #340]Add http trace http point (#527) * tracing in AbstractHTTPServer * add licence * the span exporter * design docs * fix the error on text * delete the useless dependence * remove the unused code * fix the different spanExporter * change the class name * fix gradle -build problem * design docs improve * fix the gradle.build error problem * fixed * unsure fix * fix the path name * fix check error * format code * add javadoc * checkstyle fix * unversioned files * put context into channel in advance * Update quick start docs (#656) * [MINOR] Upgrade log4j version to 2.16.0 (#654) * Update log4j version * [MINOR] update the license and add the third party license files (#657) * [MINOR] update the license and add the third party license files * [ISSUE #604]Improve the rebalance algorithm (#605) * modify:optimize flow control in downstreaming msg * modify:optimize stategy of selecting session in downstream msg * modify:optimize msg downstream,msg store in session * modify:fix bug:not a @sharable handler * modify:downstream broadcast msg asynchronously * modify:remove unneccessary interface in eventmesh-connector-api * modify:fix conflict * modify:add license in EventMeshAction * modify:fix ack problem * modify:fix exception handle when exception occured in EventMeshTcpMessageDispatcher * modify:fix log print * modify: fix issue#496,ClassCastException * modify: improve rebalance algorithm close #604 * [Feature #547] Create and upload 1.3.0-snapshot docker image (#659) * [Feature #547] Create and upload 1.3.0-snapshot docker image * grpc consumer work * [MINOR] Add third-part dependencies licenses (#650) * [MINOR] supply the license and update the third party license file name (#653) [MINOR] supply the license and update the third party license file name * [ISSUE #340]Add http trace http point (#527) * tracing in AbstractHTTPServer * add licence * the span exporter * design docs * fix the error on text * delete the useless dependence * remove the unused code * fix the different spanExporter * change the class name * fix gradle -build problem * design docs improve * fix the gradle.build error problem * fixed * unsure fix * fix the path name * fix check error * format code * add javadoc * checkstyle fix * unversioned files * put context into channel in advance * Update quick start docs (#656) * [MINOR] Upgrade log4j version to 2.16.0 (#654) * Update log4j version * [MINOR] update the license and add the third party license files (#657) * [MINOR] update the license and add the third party license files * [ISSUE #604]Improve the rebalance algorithm (#605) * modify:optimize flow control in downstreaming msg * modify:optimize stategy of selecting session in downstream msg * modify:optimize msg downstream,msg store in session * modify:fix bug:not a @sharable handler * modify:downstream broadcast msg asynchronously * modify:remove unneccessary interface in eventmesh-connector-api * modify:fix conflict * modify:add license in EventMeshAction * modify:fix ack problem * modify:fix exception handle when exception occured in EventMeshTcpMessageDispatcher * modify:fix log print * modify: fix issue#496,ClassCastException * modify: improve rebalance algorithm close #604 * [Feature #547] Create and upload 1.3.0-snapshot docker image (#659) * [Feature #547] Create and upload 1.3.0-snapshot docker image * merge from develop * GRPC producer publish API * grpc publish with cloudevents * Adding grpc publish and subscribe API examples * grpc consumer api testing and bug fixing * minor enhancement to grpc consumer Co-authored-by: xwm1992 <[email protected]> Co-authored-by: wangshaojie4039 <[email protected]> Co-authored-by: wangshaojie <[email protected]> Co-authored-by: Eason Chen <[email protected]> Co-authored-by: Wenjun Ruan <[email protected]> Co-authored-by: Nicholas Zhan <[email protected]> Co-authored-by: hagsyn <[email protected]> Co-authored-by: sarihuangshanrong <[email protected]> Co-authored-by: yuri <[email protected]> Co-authored-by: vongosling <[email protected]> Co-authored-by: ZePeng Chen <[email protected]> Co-authored-by: lrhkobe <[email protected]>
xwm1992
pushed a commit
to xwm1992/EventMesh
that referenced
this pull request
Dec 27, 2021
… from classpath (apache#631) * Fix RocketMqConsumer cannot load properties in classpath close apache#630
xwm1992
pushed a commit
that referenced
this pull request
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #630
This pr remove the refresh config from the file, since no one will actuallu use it that way, we may need to design how to adapt to configutation center like apollo or nacos