-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #456] Remove license name, add LICENSE file #535
[ISSUE #456] Remove license name, add LICENSE file #535
Conversation
8d87d4b
to
2586de2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #535 +/- ##
=============================================
- Coverage 11.20% 11.13% -0.08%
+ Complexity 389 385 -4
=============================================
Files 261 261
Lines 12296 12296
Branches 1044 1044
=============================================
- Hits 1378 1369 -9
- Misses 10800 10810 +10
+ Partials 118 117 -1
Continue to review full report at Codecov.
|
2586de2
to
caa0b5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
========================================================================
LGPL licenses
The following components are provided under the LGPL License. See project link for details.
The text of each license is also included at licenses/LICENSE-[project].txt.
hibernate-commons-annotations 5.1.2.Final: https://mvnrepository.com/artifact/org.hibernate.common/hibernate-commons-annotations/5.1.2.Final, LGPL 2.1
hibernate-core 5.4.32.Final: https://mvnrepository.com/artifact/org.hibernate/hibernate-core/5.4.32.Final, LGPL 2.1
refer to: https://www.apache.org/legal/resolved.html
LICENSE file must not include LGPL2.1 license .
@jonyangx Thanks for your reminder, this is a big mistake. I have removed these licenses, since these are not in binary jar. And now the LICENSE only contains binary dependency. |
83f3673
to
5cc34cd
Compare
5cc34cd
to
b7d5282
Compare
b7d5282
to
9eb890a
Compare
@xwm1992 I think we may still need to use a shell script to check the license, rather than use gradle license check plugin. Because the gradle plugin check result doesn't correct, some of them are not appeared in the binary file. |
9eb890a
to
5953da1
Compare
0308154
to
7adff47
Compare
7adff47
to
05ac1fe
Compare
This pr is ready to review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[ISSUE #456] Remove license name, add LICENSE file
related issue #456