[Issue #554] Removing hardcoded username and password in the project code #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merged from upstream
…ice, CountDownLatch and PreDestroy hook
# Conflicts: # eventmesh-test/src/main/java/org/apache/eventmesh/http/demo/sub/service/SubService.java
…ice, CountDownLatch and PreDestroy hook
qqeasonchen
approved these changes
Oct 13, 2021
xwm1992
approved these changes
Oct 13, 2021
xwm1992
pushed a commit
to xwm1992/EventMesh
that referenced
this pull request
Dec 27, 2021
…oject code (apache#555) * [Issue apache#337] Fix HttpSubscriber startup issue * [Issue apache#337] test commit * [Issue apache#337] revert test commit * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Address code review comment for Subscriber Demo App * [Issue apache#554] Removing hardcoded username and password in the project code Co-authored-by: j00441484 <[email protected]>
xwm1992
added a commit
to xwm1992/EventMesh
that referenced
this pull request
Dec 27, 2021
…n the project code (apache#555)" (apache#559) This reverts commit e2adda8.
xwm1992
pushed a commit
that referenced
this pull request
Aug 4, 2022
…code (#555) * [Issue #337] Fix HttpSubscriber startup issue * [Issue #337] test commit * [Issue #337] revert test commit * [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue #337] Address code review comment for Subscriber Demo App * [Issue #554] Removing hardcoded username and password in the project code Co-authored-by: j00441484 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ISSUE#554
Motivation
For better commercial adoption, I suggest to clean up any hardcoded username and password in the project code. And in the future,
Modifications
Removing hardcoded username and password in the project code
Documentation