Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing hardcoded username and password in the project code #554

Closed
jinrongluo opened this issue Oct 12, 2021 · 3 comments
Closed

Removing hardcoded username and password in the project code #554

jinrongluo opened this issue Oct 12, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@jinrongluo
Copy link
Contributor

Enhancement Request

When reviewing the eventmesh project code, we found out there is not a best practice to hardcode username and password in the code, which can be potential security and compliance issue when the project is deploy to a company's production environment.

For better commercial adoption, I suggest to clean up any hardcoded username and password in the project code. And in the future, don't hard code username and password in the project code.

Is your enhancement request related to a problem? Please describe

Clean up any hardcoded username and password in the project code.

Describe the solution you'd like

Clean up any hardcoded username and password in the project code.
@jinrongluo jinrongluo added the enhancement New feature or request label Oct 12, 2021
jinrongluo added a commit to jinrongluo/incubator-eventmesh that referenced this issue Oct 12, 2021
@jinrongluo
[Issue apache#554] Removing hardcoded username and password in the pr…
81e23bf 
…oject code
xwm1992 pushed a commit that referenced this issue Oct 13, 2021
@jinrongluo
[Issue #554] Removing hardcoded username and password in the project …
e2adda8 
…code (#555)

* [Issue #337] Fix HttpSubscriber startup issue

* [Issue #337] test commit

* [Issue #337] revert test commit

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Address code review comment for Subscriber Demo App

* [Issue #554] Removing hardcoded username and password in the project code

Co-authored-by: j00441484 <[email protected]>
@xwm1992 xwm1992 closed this as completed Oct 13, 2021
xwm1992 added a commit that referenced this issue Oct 16, 2021
@xwm1992
Revert "[Issue #554] Removing hardcoded username and password in the …
aad71fa 
…project code (#555)"

This reverts commit e2adda8.
xwm1992 added a commit that referenced this issue Oct 16, 2021
@xwm1992
Revert "[Issue #554] Removing hardcoded username and password in the …
9337efc 
…project code (#555)" (#559)

This reverts commit e2adda8.
@xwm1992 xwm1992 reopened this Oct 16, 2021
@xwm1992
Copy link
Contributor

xwm1992 commented Oct 16, 2021 •
edited
Loading

I've revert this issue, because this may cause JSON convert exception during http subscribe, please take a look @jinrongluo .
image
image

jinrongluo added a commit to jinrongluo/incubator-eventmesh that referenced this issue Oct 18, 2021
@jinrongluo
[Issue apache#554] removing hardcoded username and password
e685728
@jinrongluo
Copy link
Contributor Author

@xwm1992 Thanks for catching this bug. I have another PR to fix this issue. I tested in my development environment. Thanks.

qqeasonchen pushed a commit that referenced this issue Oct 19, 2021
@jinrongluo
[Issue#554] removing hardcoded username and password (#560)
dd3385f 
* [Issue #337] Fix HttpSubscriber startup issue

* [Issue #337] test commit

* [Issue #337] revert test commit

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Address code review comment for Subscriber Demo App

* [Issue #554] removing hardcoded username and password

Co-authored-by: j00441484 <[email protected]>
@jinrongluo
Copy link
Contributor Author

fix merged. close

xwm1992 pushed a commit to xwm1992/EventMesh that referenced this issue Dec 27, 2021
@jinrongluo @xwm1992
[Issue apache#554] Removing hardcoded username and password in the pr…
9905876 
…oject code (apache#555)

* [Issue apache#337] Fix HttpSubscriber startup issue

* [Issue apache#337] test commit

* [Issue apache#337] revert test commit

* [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue apache#337] Address code review comment for Subscriber Demo App

* [Issue apache#554] Removing hardcoded username and password in the project code

Co-authored-by: j00441484 <[email protected]>
xwm1992 added a commit to xwm1992/EventMesh that referenced this issue Dec 27, 2021
@xwm1992
Revert "[Issue apache#554] Removing hardcoded username and password i…
e130143 
…n the project code (apache#555)" (apache#559)

This reverts commit e2adda8.
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this issue Dec 27, 2021
@jinrongluo @xwm1992
[Issue#554] removing hardcoded username and password (apache#560)
a5cbbb8 
* [Issue apache#337] Fix HttpSubscriber startup issue

* [Issue apache#337] test commit

* [Issue apache#337] revert test commit

* [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue apache#337] Address code review comment for Subscriber Demo App

* [Issue apache#554] removing hardcoded username and password

Co-authored-by: j00441484 <[email protected]>
xwm1992 pushed a commit that referenced this issue Aug 4, 2022
@jinrongluo
[Issue #554] Removing hardcoded username and password in the project …
eacc978 
…code (#555)

* [Issue #337] Fix HttpSubscriber startup issue

* [Issue #337] test commit

* [Issue #337] revert test commit

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Address code review comment for Subscriber Demo App

* [Issue #554] Removing hardcoded username and password in the project code

Co-authored-by: j00441484 <[email protected]>
xwm1992 added a commit that referenced this issue Aug 4, 2022
@xwm1992
Revert "[Issue #554] Removing hardcoded username and password in the …
9b2b1c7 
…project code (#555)" (#559)

This reverts commit e2adda8.
xwm1992 pushed a commit that referenced this issue Aug 4, 2022
@jinrongluo
[Issue#554] removing hardcoded username and password (#560)
0439658 
* [Issue #337] Fix HttpSubscriber startup issue

* [Issue #337] test commit

* [Issue #337] revert test commit

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Address code review comment for Subscriber Demo App

* [Issue #554] removing hardcoded username and password

Co-authored-by: j00441484 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xwm1992 @jinrongluo