Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #528] enhance Retry support for HTTP and TCP processors. #529

Merged
merged 24 commits into from
Sep 30, 2021

Conversation

jinrongluo
Copy link
Contributor

Motivation

add Retry support to

  • HTTP SendMessage processors using SendMessageContext
  • TCP MessageTransfer task using SessionSender and UpStreamMsgContext

Modifications

The following are the major classes with changes:

HTTP side

  • SendAsyncMessageProcessor
  • SendSyncMessageProcessor

TCP side

  • RetryContext
  • EventMeshTcpRetryer
  • UpStreamMsgContext
  • DownStreamMSgContext
  • MessageTransferTask

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #529 (e4b9a1f) into develop (9c1d21f) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #529      +/-   ##
=============================================
- Coverage      11.03%   10.98%   -0.05%     
- Complexity       376      377       +1     
=============================================
  Files            257      258       +1     
  Lines          12157    12212      +55     
  Branches        1032     1035       +3     
=============================================
+ Hits            1341     1342       +1     
- Misses         10701    10754      +53     
- Partials         115      116       +1     
Impacted Files Coverage Δ
...che/eventmesh/runtime/boot/EventMeshTCPServer.java 0.00% <ø> (ø)
...ocol/http/processor/SendAsyncMessageProcessor.java 0.00% <0.00%> (ø)
...tocol/http/processor/SendSyncMessageProcessor.java 0.00% <0.00%> (ø)
.../protocol/tcp/client/group/ClientGroupWrapper.java 0.00% <0.00%> (ø)
.../tcp/client/session/push/DownStreamMsgContext.java 0.00% <0.00%> (ø)
.../tcp/client/session/retry/EventMeshTcpRetryer.java 0.00% <0.00%> (ø)
...rotocol/tcp/client/session/retry/RetryContext.java 0.00% <0.00%> (ø)
...rotocol/tcp/client/session/send/SessionSender.java 0.00% <0.00%> (ø)
...ol/tcp/client/session/send/UpStreamMsgContext.java 0.00% <0.00%> (ø)
.../protocol/tcp/client/task/MessageTransferTask.java 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c1d21f...e4b9a1f. Read the comment docs.

@xwm1992 xwm1992 merged commit b9abbcd into apache:develop Sep 30, 2021
@jinrongluo jinrongluo deleted the develop-retry branch October 12, 2021 20:29
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this pull request Dec 27, 2021
…apache#529)

* [Issue apache#337] Fix HttpSubscriber startup issue

* [Issue apache#337] test commit

* [Issue apache#337] revert test commit

* [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue apache#337] Address code review comment for Subscriber Demo App

* [Issue apache#528] enhance Retry support for HTTP and TCP processors.

* [Issue apache#528] fixing checkstyle issue

* [Issue apache#528] Fix taskExecuteTime in TCP ClientGroupWrapper UpStreamMsgContext

Co-authored-by: j00441484 <[email protected]>
xwm1992 pushed a commit that referenced this pull request Aug 4, 2022
* [Issue #337] Fix HttpSubscriber startup issue

* [Issue #337] test commit

* [Issue #337] revert test commit

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Address code review comment for Subscriber Demo App

* [Issue #528] enhance Retry support for HTTP and TCP processors.

* [Issue #528] fixing checkstyle issue

* [Issue #528] Fix taskExecuteTime in TCP ClientGroupWrapper UpStreamMsgContext

Co-authored-by: j00441484 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants