Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Retry support to HTTP SendMessage processor and TCP MessageTransfer task #528

Closed
jinrongluo opened this issue Sep 20, 2021 · 3 comments
Closed

Adding Retry support to HTTP SendMessage processor and TCP MessageTransfer task #528

jinrongluo opened this issue Sep 20, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@jinrongluo
Copy link
Contributor

Enhancement Request

Currently in Eventmesh-runtime, Retry logic is added to the following functions:

  • HTTP BatchSend processors, using SendMessageContext
  • HTTP Pusher, using AsyncHttpPusherRequest
  • TCP SessionPusher using DownStreamMsgContext

But HTTP SendMessage processors and TCP MessageTransfer task don't have Retry support.

Is your enhancement request related to a problem? Please describe

This issue is to add Retry support to

  • HTTP SendMessage processors using SendMessageContext
  • TCP MessageTransfer task using SessionSender and UpStreamMsgContext

Describe the solution you'd like

This issue is to add Retry support to

  • HTTP SendMessage processors using SendMessageContext
  • TCP MessageTransfer task using SessionSender and UpStreamMsgContext
@jinrongluo jinrongluo added the enhancement New feature or request label Sep 20, 2021
@jinrongluo
Copy link
Contributor Author

@vongosling

jinrongluo added a commit to jinrongluo/incubator-eventmesh that referenced this issue Sep 20, 2021
@jinrongluo
[Issue apache#528] enhance Retry support for HTTP and TCP processors.
2cfd6ca
@jinrongluo
Copy link
Contributor Author

PR created for this issue. please review. Thanks.

#529

jinrongluo added a commit to jinrongluo/incubator-eventmesh that referenced this issue Sep 20, 2021
@jinrongluo
[Issue apache#528] fixing checkstyle issue
6fe7b41
jinrongluo added a commit to jinrongluo/incubator-eventmesh that referenced this issue Sep 27, 2021
@jinrongluo
[Issue apache#528] Fix taskExecuteTime in TCP ClientGroupWrapper UpSt…
19b50d7 
…reamMsgContext
xwm1992 pushed a commit that referenced this issue Sep 30, 2021
@jinrongluo
[Issue #528] enhance Retry support for HTTP and TCP processors. (#529)
b9abbcd 
* [Issue #337] Fix HttpSubscriber startup issue

* [Issue #337] test commit

* [Issue #337] revert test commit

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Address code review comment for Subscriber Demo App

* [Issue #528] enhance Retry support for HTTP and TCP processors.

* [Issue #528] fixing checkstyle issue

* [Issue #528] Fix taskExecuteTime in TCP ClientGroupWrapper UpStreamMsgContext

Co-authored-by: j00441484 <[email protected]>
@jinrongluo
Copy link
Contributor Author

PR merged. close issue. thanks.

xwm1992 pushed a commit to xwm1992/EventMesh that referenced this issue Dec 27, 2021
@jinrongluo @xwm1992
[Issue apache#528] enhance Retry support for HTTP and TCP processors. (…
73eac00 
…apache#529)

* [Issue apache#337] Fix HttpSubscriber startup issue

* [Issue apache#337] test commit

* [Issue apache#337] revert test commit

* [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue apache#337] Address code review comment for Subscriber Demo App

* [Issue apache#528] enhance Retry support for HTTP and TCP processors.

* [Issue apache#528] fixing checkstyle issue

* [Issue apache#528] Fix taskExecuteTime in TCP ClientGroupWrapper UpStreamMsgContext

Co-authored-by: j00441484 <[email protected]>
xwm1992 pushed a commit that referenced this issue Aug 4, 2022
@jinrongluo
[Issue #528] enhance Retry support for HTTP and TCP processors. (#529)
e1e9eb0 
* [Issue #337] Fix HttpSubscriber startup issue

* [Issue #337] test commit

* [Issue #337] revert test commit

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Address code review comment for Subscriber Demo App

* [Issue #528] enhance Retry support for HTTP and TCP processors.

* [Issue #528] fixing checkstyle issue

* [Issue #528] Fix taskExecuteTime in TCP ClientGroupWrapper UpStreamMsgContext

Co-authored-by: j00441484 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jinrongluo