Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #4733] Substitute e.printStackTrace() with log.error() #4754

Merged
merged 3 commits into from
Jan 21, 2024
Merged

[ISSUE #4733] Substitute e.printStackTrace() with log.error() #4754

merged 3 commits into from
Jan 21, 2024

Conversation

scwlkq
Copy link
Contributor

@scwlkq scwlkq commented Jan 20, 2024

Fixes #4733 .

Motivation

Modifications

Substitute e.printStackTrace() with log.error()

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia Pil0tXia changed the title [ISSUE #4733]Substitute e.printStackTrace() with log.error() [ISSUE #4733] Substitute e.printStackTrace() with log.error() Jan 20, 2024
@scwlkq scwlkq requested a review from Pil0tXia January 20, 2024 16:41
@scwlkq
Copy link
Contributor Author

scwlkq commented Jan 20, 2024 •
edited
Loading

image
Is "stopped" suitable here? Or there may be other words.

@scwlkq scwlkq requested a review from Pil0tXia January 21, 2024 05:06
Pil0tXia
Pil0tXia approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pil0tXia Pil0tXia merged commit 1d30733 into apache:master Jan 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pil0tXia Pil0tXia Pil0tXia approved these changes

@mxsm mxsm mxsm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Substitute e.printStackTrace() with log.error()
3 participants
@scwlkq @mxsm @Pil0tXia