[ISSUE #4733] Substitute e.printStackTrace() with log.error() (#4754)

* Substitute e.printStackTrace() with log.error() * add exception arg * Modify the wording of the log
apache · Jan 21, 2024 · 1d30733 · 1d30733
1 parent 39c8293
commit 1d30733
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/eventmesh-common/src/test/java/org/apache/eventmesh/common/ThreadWrapperTest.java b/eventmesh-common/src/test/java/org/apache/eventmesh/common/ThreadWrapperTest.java
@@ -24,6 +24,9 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Timeout;
 
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
 public class ThreadWrapperTest {
 
     @Test
@@ -74,7 +77,7 @@ public void run() {
                 try {
                     TimeUnit.MILLISECONDS.sleep(500);
                 } catch (InterruptedException e) {
-                    e.printStackTrace();
+                    log.error("[ThreadWrapperTest][shutdown] InterruptedException", e);
                 }
                 counter.set(100);
             }
@@ -136,4 +139,4 @@ public void run() {
         wrapper.setDaemon(daemon);
         return wrapper;
     }
-}
+}
diff --git a/...entmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java b/...entmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java
@@ -276,7 +276,6 @@ public void stop() {
         try {
             source.stop();
         } catch (Exception e) {
-            e.printStackTrace();
             log.error("source destroy error", e);
         }
         log.info("pollService stopping");
@@ -330,15 +329,15 @@ public boolean commitOffsets() {
             log.info("{} Committing offsets for {} acknowledged messages", this, committableOffsets.numCommittableMessages());
             if (committableOffsets.hasPending()) {
                 log.debug("{} There are currently {} pending messages spread across {} source partitions whose offsets will not be committed. "
-                    + "The source partition with the most pending messages is {}, with {} pending messages",
+                        + "The source partition with the most pending messages is {}, with {} pending messages",
                     this,
                     committableOffsets.numUncommittableMessages(),
                     committableOffsets.numDeques(),
                     committableOffsets.largestDequePartition(),
                     committableOffsets.largestDequeSize());
             } else {
                 log.debug("{} There are currently no pending messages for this offset commit; "
-                    + "all messages dispatched to the task's producer since the last commit have been acknowledged",
+                        + "all messages dispatched to the task's producer since the last commit have been acknowledged",
                     this);
             }
         }

diff --git a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
@@ -73,7 +73,7 @@ public void close() {
             task.cancel(false);
             super.close();
         } catch (Exception e) {
-            e.printStackTrace();
+            log.error("PubClientImpl|{}|close failed!", clientNo, e);
         }
     }