[ISSUE#4095] Code Optimization and Interrupeted Exception handling.[EtcdCustomService] #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himansh295
changed the title
himansh295
changed the title
|
Please specify the number of the issue fixed by this PR. |
Alonexc
reviewed
Aug 15, 2023
| @@ -68,6 +68,9 @@ public List<EventMeshServicePubTopicInfo> findEventMeshServicePubTopicInfos() th | |||
| return eventMeshServicePubTopicInfoList; | |||
| } | |||
| } catch (Exception e) { | |||
| if(e instanceof InterruptedException) { | |||
There was a problem hiding this comment.
I think it would be better to put it after the log message.
mxsm
changed the title
mxsm
reviewed
Aug 15, 2023
|
Please resolve conflicts. |
|
Hi @himansh295 , the issue has been accomplished in #4752. Do you have any additional information to share? Feel free to share your latest insights with us. If you feel that your issue has been resolved, you are welcome to close it. We sincerely appreciate your contributions to Apache EventMesh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4095 .
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation