[Enhancement] Code optimization. [EtcdCustomService]

[Alonexc]

Search before asking

• I had searched in the issues and found no similar issues.

Enhancement Request

analysis and explanation:
a. InterruptedExceptions should never be ignored in the code, and simply logging the exception counts in this case as "ignoring". The throwing of the InterruptedException clears the interrupted state of the Thread, so if the exception is not handled properly the information that the thread was interrupted will be lost. Instead, InterruptedExceptions should either be rethrown - immediately or after cleaning up the method’s state - or the thread should be re-interrupted by calling Thread.interrupt() even if this is supposed to be a single-threaded application. Any other course of action risks delaying thread shutdown and loses the information that the thread was interrupted - probably without finishing its task.
b. Declaring a variable only to immediately return or throw it is a bad practice.
Some developers argue that the practice improves code readability, because it enables them to explicitly name what is being returned. However, this variable is an internal implementation detail that is not exposed to the callers of the method. The method name should be sufficient for callers to know exactly what will be returned.

Describe the solution you'd like

a. restore interrupted state

b. inline variable

Are you willing to submit PR?

• Yes I am willing to submit a PR!

[himansh295]

@xwm1992 Can I work on this issue ?

[Alonexc]

sure