test(deps): move dependencies that are required only by VRT to dedicated folder #18725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edicated folder to speed up npm install.
echarts-bot
bot
added
PR: author is committer
PR: awaiting review
PR: doc unchanged
labels
|
Thanks for your contribution! The pull request is marked to be |
…l test & add eslint config for `runTest` folder
Ovilia
approved these changes
Jun 13, 2023
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Currently, the dependencies that are required only by the VRT tool will also be installed even if we don't run the VRT tool. As these packages are defined in the root
package.json, they will be installed when runningnpm install. Especially, thecwebp-binmay need to be fetched from the GitHub Release server, which is not friendly for the Chinese and is very likely to fail. If we move it to the dedicated test folder, it can speed up npm install and avoid some potential problems for beginners.The dependabot upgraded
huskyto the latest version 8.x in 73e566c and the git hooks didn't work anymore due to the breaking change. So I fixed it in this PR.Add tips for installing dependencies first before running the VRT tool.
Fixed issues
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information