Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip content changes with axis extent when 'triggerOn' set to 'click' #16939

Merged
merged 2 commits into from
Apr 28, 2022
Merged

fix: tooltip content changes with axis extent when 'triggerOn' set to 'click' #16939

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62ab379
fix: tooltip content won't change with axis extent when triggerOn set…
jiawulin001 Apr 24, 2022
1258fa7
fix: use short phrase 'triggerOn' instead
jiawulin001 Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/component/tooltip/TooltipView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,14 +249,16 @@ class TooltipView extends ComponentView {
const tooltipModel = this._tooltipModel;
const ecModel = this._ecModel;
const api = this._api;
const triggerOn = tooltipModel.get('triggerOn');

// Try to keep the tooltip show when refreshing
if (this._lastX != null
&& this._lastY != null
// When user is willing to control tooltip totally using API,
// self.manuallyShowTip({x, y}) might cause tooltip hide,
// which is not expected.
&& tooltipModel.get('triggerOn') !== 'none'
&& triggerOn !== 'none'
&& triggerOn !== 'click'
) {
const self = this;
clearTimeout(this._refreshUpdateTimeout);
Expand Down