Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip content changes with axis extent when 'triggerOn' set to 'click' #16939

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

jiawulin001
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix the problem that the tooltip changes as the axis extent changes when triggerOn is set to click

Fixed issues

Details

Before: What was the problem?

When tooltip.triggerOn is set to 'click', tooltip is expected to stay the same until user clicks another item. But the tool tip content will change with axis extent now after zooming in and slide the axis around. The reason causing this is stated in #16930 (comment)

before#16930

After: How is it fixed in this PR?

The content of tooltip will stay the same until user clicks another item.

after#16930

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Apr 24, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang added this to the 5.3.3 milestone Apr 27, 2022
@pissang pissang merged commit f783cd8 into apache:master Apr 28, 2022
@echarts-bot
Copy link

echarts-bot bot commented Apr 28, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Tooltip formatter gives wrong values
2 participants