Fixes #13684: delete outdated metrics port assertions #13717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #13717 +/- ##
=======================================
Coverage 70.34% 70.34%
=======================================
Files 1606 1606
Lines 70033 70020 -13
Branches 10104 10102 -2
=======================================
- Hits 49263 49254 -9
+ Misses 16133 16128 -5
- Partials 4637 4638 +1 ☔ View full report in Codecov by Sentry. |
|
@songxiaosheng PTAL |
|
please remove config from dubbo.xsd also |
done d34de3c |
|
AlbumenJ
approved these changes
Feb 2, 2024
This was referenced Feb 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes #13684
Brief changelog
bitgorust@d862f16
Outdated methods and fields are deleted as discussed in #13684