Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13684: remove deprecated port non-null assertion in case start failure #13705

Closed
wants to merge 2 commits into from

Conversation

bitgorust
Copy link
Contributor

@bitgorust bitgorust commented Jan 30, 2024

What is the purpose of the change

Fixes #13684

Brief changelog

Remove L280 and L282 in AbstractInterfaceConfig bitgorust@c375096

if (!StringUtils.isEquals(protocol, PROTOCOL_PROMETHEUS)) {
Assert.notEmptyString(metricsConfig.getPort(), "Metrics port cannot be null");
map.put("metrics.protocol", protocol);
map.put("metrics.port", metricsConfig.getPort());
}

@bitgorust bitgorust changed the title fix: remove deprecated port non-null assertion in case start failure fix: remove deprecated port non-null assertion in case start failure #13684 Jan 30, 2024
@bitgorust bitgorust changed the title fix: remove deprecated port non-null assertion in case start failure #13684 Fixes #13684: remove deprecated port non-null assertion in case start failure Jan 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29b0c72) 70.34% compared to head (c8083f3) 70.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13705      +/-   ##
==========================================
- Coverage   70.34%   70.31%   -0.03%     
==========================================
  Files        1606     1606              
  Lines       70033    70031       -2     
  Branches    10104    10104              
==========================================
- Hits        49263    49245      -18     
- Misses      16133    16146      +13     
- Partials     4637     4640       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@songxiaosheng
Copy link
Member

image @bitgorust How about deleting the outdated methods and testing them out

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AlbumenJ
Copy link
Member

AlbumenJ commented Feb 2, 2024

Fixed in #13717

@AlbumenJ AlbumenJ closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.IllegalArgumentException: Metrics port cannot be null
4 participants