-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize parameters for interface-level registration #13304
Customize parameters for interface-level registration #13304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chickenlj PTAL
Nice try |
# Conflicts: # dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
…-parameters # Conflicts: # dubbo-distribution/dubbo-all/pom.xml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #13304 +/- ##
==========================================
- Coverage 70.38% 70.35% -0.03%
==========================================
Files 1602 1603 +1
Lines 69873 69881 +8
Branches 10090 10092 +2
==========================================
- Hits 49177 49164 -13
- Misses 16071 16082 +11
- Partials 4625 4635 +10 ☔ View full report in Codecov by Sentry. |
Here are two inputs:
|
Okay, I‘ll take a look. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@chickenlj PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
Refer: #13294
Brief changelog
Verifying this change
Checklist