Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize parameters for interface-level registration #13304

Merged
merged 19 commits into from
Dec 20, 2023

Conversation

finefuture
Copy link
Contributor

What is the purpose of the change

Refer: #13294

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chickenlj PTAL

@AlbumenJ
Copy link
Member

AlbumenJ commented Nov 4, 2023

Nice try

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d1bb26) 70.38% compared to head (3b780ac) 70.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13304      +/-   ##
==========================================
- Coverage   70.38%   70.35%   -0.03%     
==========================================
  Files        1602     1603       +1     
  Lines       69873    69881       +8     
  Branches    10090    10092       +2     
==========================================
- Hits        49177    49164      -13     
- Misses      16071    16082      +11     
- Partials     4625     4635      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chickenlj
Copy link
Contributor

Here are two inputs:

  1. dubbo.properties also supports customization of the keys included in the simplified registry url.
  2. ServiceDiscovery also has metadata parameter SPI customizer, please check and make sure this SPI is consistency with that one regarding naming and how they work.

@finefuture
Copy link
Contributor Author

Here are two inputs:

  1. dubbo.properties also supports customization of the keys included in the simplified registry url.
  2. ServiceDiscovery also has metadata parameter SPI customizer, please check and make sure this SPI is consistency with that one regarding naming and how they work.

Okay, I‘ll take a look.

Copy link

sonarcloud bot commented Dec 15, 2023

@AlbumenJ
Copy link
Member

@chickenlj PTAL

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 9df0d15 into apache:3.2 Dec 20, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants