-
Notifications
You must be signed in to change notification settings - Fork 26.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Customize parameters for interface-level registration (#13304)
- Loading branch information
1 parent
d685ff2
commit 9df0d15
Showing
5 changed files
with
193 additions
and
92 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 120 additions & 0 deletions
120
...-api/src/main/java/org/apache/dubbo/registry/integration/DefaultServiceURLCustomizer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.dubbo.registry.integration; | ||
|
||
import org.apache.dubbo.common.URL; | ||
import org.apache.dubbo.common.utils.CollectionUtils; | ||
import org.apache.dubbo.common.utils.StringUtils; | ||
import org.apache.dubbo.rpc.model.ApplicationModel; | ||
|
||
import java.util.Arrays; | ||
import java.util.Map; | ||
import java.util.stream.Stream; | ||
|
||
import static org.apache.dubbo.common.constants.CommonConstants.ALIVE_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.ANYHOST_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.BACKGROUND_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.COMMA_SPLIT_PATTERN; | ||
import static org.apache.dubbo.common.constants.CommonConstants.CORE_THREADS_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.EXECUTOR_MANAGEMENT_MODE; | ||
import static org.apache.dubbo.common.constants.CommonConstants.EXTRA_KEYS_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.HIDE_KEY_PREFIX; | ||
import static org.apache.dubbo.common.constants.CommonConstants.INTERFACE_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.METHODS_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.MONITOR_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.PID_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.QUEUES_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.REGISTRY_LOCAL_FILE_CACHE_ENABLED; | ||
import static org.apache.dubbo.common.constants.CommonConstants.THREADPOOL_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.THREADS_KEY; | ||
import static org.apache.dubbo.common.constants.CommonConstants.THREAD_NAME_KEY; | ||
import static org.apache.dubbo.common.constants.FilterConstants.VALIDATION_KEY; | ||
import static org.apache.dubbo.common.constants.QosConstants.ACCEPT_FOREIGN_IP; | ||
import static org.apache.dubbo.common.constants.QosConstants.QOS_ENABLE; | ||
import static org.apache.dubbo.common.constants.QosConstants.QOS_HOST; | ||
import static org.apache.dubbo.common.constants.QosConstants.QOS_PORT; | ||
import static org.apache.dubbo.common.constants.RegistryConstants.REGISTER_MODE_KEY; | ||
import static org.apache.dubbo.registry.Constants.SIMPLIFIED_KEY; | ||
import static org.apache.dubbo.registry.integration.RegistryProtocol.DEFAULT_REGISTER_PROVIDER_KEYS; | ||
import static org.apache.dubbo.remoting.Constants.BIND_IP_KEY; | ||
import static org.apache.dubbo.remoting.Constants.BIND_PORT_KEY; | ||
import static org.apache.dubbo.rpc.Constants.INTERFACES; | ||
|
||
public class DefaultServiceURLCustomizer implements ServiceURLCustomizer { | ||
|
||
private static final String[] excludedParameters = new String[] { | ||
MONITOR_KEY, | ||
BIND_IP_KEY, | ||
BIND_PORT_KEY, | ||
QOS_ENABLE, | ||
QOS_HOST, | ||
QOS_PORT, | ||
ACCEPT_FOREIGN_IP, | ||
VALIDATION_KEY, | ||
INTERFACES, | ||
REGISTER_MODE_KEY, | ||
PID_KEY, | ||
REGISTRY_LOCAL_FILE_CACHE_ENABLED, | ||
EXECUTOR_MANAGEMENT_MODE, | ||
BACKGROUND_KEY, | ||
ANYHOST_KEY, | ||
THREAD_NAME_KEY, | ||
THREADPOOL_KEY, | ||
ALIVE_KEY, | ||
QUEUES_KEY, | ||
CORE_THREADS_KEY, | ||
THREADS_KEY | ||
}; | ||
|
||
@Override | ||
public URL customize(URL serviceURL, ApplicationModel applicationModel) { | ||
boolean simplified = (boolean) serviceURL.getAttribute(SIMPLIFIED_KEY, false); | ||
if (simplified) { | ||
String extraKeys = (String) serviceURL.getAttribute(EXTRA_KEYS_KEY, ""); | ||
// if path is not the same as interface name then we should keep INTERFACE_KEY, | ||
// otherwise, the registry structure of zookeeper would be '/dubbo/path/providers', | ||
// but what we expect is '/dubbo/interface/providers' | ||
if (!serviceURL.getPath().equals(serviceURL.getParameter(INTERFACE_KEY))) { | ||
if (StringUtils.isNotEmpty(extraKeys)) { | ||
extraKeys += ","; | ||
} | ||
extraKeys += INTERFACE_KEY; | ||
} | ||
String[] paramsToRegistry = Stream.concat( | ||
Arrays.stream(DEFAULT_REGISTER_PROVIDER_KEYS), | ||
Arrays.stream(COMMA_SPLIT_PATTERN.split(extraKeys))) | ||
.toArray(String[]::new); | ||
return URL.valueOf(serviceURL, paramsToRegistry, serviceURL.getParameter(METHODS_KEY, (String[]) null)); | ||
} | ||
return serviceURL.removeParameters(getFilteredKeys(serviceURL)).removeParameters(excludedParameters); | ||
} | ||
|
||
@Override | ||
public int getPriority() { | ||
return MAX_PRIORITY; | ||
} | ||
|
||
private String[] getFilteredKeys(URL url) { | ||
Map<String, String> params = url.getParameters(); | ||
if (CollectionUtils.isNotEmptyMap(params)) { | ||
return params.keySet().stream() | ||
.filter(k -> k.startsWith(HIDE_KEY_PREFIX)) | ||
.toArray(String[]::new); | ||
} | ||
return new String[0]; | ||
} | ||
} |
Oops, something went wrong.