Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dubbo 3.3 support compilation with jdk 1.8 #13227

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Oct 17, 2023

What is the purpose of the change

See: #13226

Brief changelog

Use maven profile activation to include module dubbo-config-spring6 only when the jdk version is >= 17.

Verifying this change

Compile successfully with jdk 1.8

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.40%. Comparing base (027aba5) to head (8539ace).
Report is 926 commits behind head on 3.3.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.3   #13227   +/-   ##
=========================================
  Coverage     68.40%   68.40%           
  Complexity        8        8           
=========================================
  Files          1717     1717           
  Lines         70801    70801           
  Branches      10236    10236           
=========================================
+ Hits          48429    48431    +2     
  Misses        17690    17690           
+ Partials       4682     4680    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dubbo-config/pom.xml Outdated Show resolved Hide resolved
@oxsean oxsean force-pushed the bugfix-13226-support-jdk-1.8 branch from 7bb4530 to 8539ace Compare October 18, 2023 03:08
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlbumenJ AlbumenJ merged commit 7696e1b into apache:3.3 Oct 18, 2023
14 checks passed
@oxsean oxsean deleted the bugfix-13226-support-jdk-1.8 branch October 26, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants