Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failure in dubbo-config-spring6 module with JDK 1.8 on the 3.3 branch #13226

Closed
oxsean opened this issue Oct 17, 2023 · 0 comments
Closed
Labels
type/bug Bugs to being fixed

Comments

@oxsean
Copy link
Collaborator

oxsean commented Oct 17, 2023

Environment

  • Dubbo version: 3.3
  • Operating System version: Windows 11
  • Java version: 1.8

Steps to Reproduce the Issue

1.Compile Dubbo using JDK 1.8, but compilation failure in the dubbo-config-spring6 module.

Example

Using the 3.3 branch.

Expected Behavior

Dubbo 3.3 should be able to compile successfully with jdk 1.8.

Actual Behavior

Compilation fails with the error message:"class file has the wrong version 61.0, should be 52.0".

Proposal

The root cause is that dubbo-config-spring6 requires jdk 17. We can use maven profile activation to include this module only when the jdk version is >= 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bugs to being fixed
Projects
None yet
Development

No branches or pull requests

1 participant