Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](Serde-2.1) fix potential mem leak in array serde write_one_cell_to_json #41339

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[Fix](Serde-2.1) fix potential mem leak in array serde write_one_cell_to_json #41339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions be/src/vec/data_types/serde/data_type_array_serde.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,20 +229,24 @@ void DataTypeArraySerDe::write_one_cell_to_jsonb(const IColumn& column, JsonbWri
Status DataTypeArraySerDe::write_one_cell_to_json(const IColumn& column, rapidjson::Value& result,
rapidjson::Document::AllocatorType& allocator,
Arena& mem_pool, int row_num) const {
// Use allocator instead of stack memory, since rapidjson hold the reference of String value
// otherwise causes stack use after free
auto& column_array = static_cast<const ColumnArray&>(column);
if (row_num > column_array.size()) {
return Status::InternalError("row num {} out of range {}!", row_num, column_array.size());
}
// void* mem = allocator.Malloc(sizeof(vectorized::Field));
void* mem = mem_pool.alloc(sizeof(vectorized::Field));
if (!mem) {
return Status::InternalError("Malloc failed");
}
vectorized::Field* array = new (mem) vectorized::Field(column_array[row_num]);
auto res = check_column_const_set_readability(column, row_num);
ColumnPtr ptr = res.first;
row_num = res.second;

const auto& data_column = assert_cast<const ColumnArray&>(*ptr);
const auto& offsets = data_column.get_offsets();

size_t offset = offsets[row_num - 1];
size_t next_offset = offsets[row_num];

convert_field_to_rapidjson(*array, result, allocator);
const IColumn& nested_column = data_column.get_data();
result.SetArray();
for (size_t i = offset; i < next_offset; ++i) {
rapidjson::Value val;
RETURN_IF_ERROR(
nested_serde->write_one_cell_to_json(nested_column, val, allocator, mem_pool, i));
result.PushBack(val, allocator);
}
return Status::OK();
}

Expand Down
Loading